From: Alexandra Ellwood <lxs@mit.edu>
Date: Wed, 3 Oct 2007 20:13:55 +0000 (+0000)
Subject: Removed NOP line of code from krb5_fcc_next_cred()
X-Git-Tag: krb5-1.7-alpha1~818
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b8e0037c076dfe2218cf14084ec249667d5bf87e;p=krb5.git

Removed NOP line of code from krb5_fcc_next_cred()

cursor = (krb5_cc_cursor *) fcursor;

does nothing for a function with a prototype

krb5_fcc_next_cred(krb5_context context, krb5_ccache id,
	krb5_cc_cursor *cursor, krb5_creds *creds)

The correct line of code would be:

*cursor = (krb5_cc_cursor) fcursor;

Except it isn't necessary because fcursor isn't modified
by krb5_fcc_next_cred().  Looks like code was copied from
krb5_fcc_start_seq_get() and since the line was a NOP
no one noticed it.

ticket: new

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20085 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/krb5/ccache/cc_file.c b/src/lib/krb5/ccache/cc_file.c
index 49ba47943..9abf93f3d 100644
--- a/src/lib/krb5/ccache/cc_file.c
+++ b/src/lib/krb5/ccache/cc_file.c
@@ -1903,7 +1903,6 @@ krb5_fcc_next_cred(krb5_context context, krb5_ccache id, krb5_cc_cursor *cursor,
      TCHECK(kret);
      
      fcursor->pos = fcc_lseek(d, (off_t) 0, SEEK_CUR);
-     cursor = (krb5_cc_cursor *) fcursor;
 
 lose:
      MAYBE_CLOSE (context, id, kret);