From: David Bremner Date: Tue, 2 Sep 2014 06:15:13 +0000 (+1700) Subject: Re: [PATCH] lib: Fix endless upgrade problem X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b815a879f1f87b48da5b78b786d8863d74867797;p=notmuch-archives.git Re: [PATCH] lib: Fix endless upgrade problem --- diff --git a/56/80d3e4d5b1a389eb69a6a83bd05a145433ec58 b/56/80d3e4d5b1a389eb69a6a83bd05a145433ec58 new file mode 100644 index 000000000..48ff778a8 --- /dev/null +++ b/56/80d3e4d5b1a389eb69a6a83bd05a145433ec58 @@ -0,0 +1,68 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 76B32431FD8 + for ; Mon, 1 Sep 2014 23:15:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3tvwLL+0J75I for ; + Mon, 1 Sep 2014 23:15:23 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C1FB0431FD2 + for ; Mon, 1 Sep 2014 23:15:23 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1XOhNA-0005W2-66; Tue, 02 Sep 2014 03:15:20 -0300 +Received: (nullmailer pid 20558 invoked by uid 1000); Tue, 02 Sep 2014 + 06:15:13 -0000 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] lib: Fix endless upgrade problem +In-Reply-To: <1409611747-32141-1-git-send-email-amdragon@mit.edu> +References: <1409611747-32141-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.18.1+85~gcca05ac (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 01 Sep 2014 23:15:13 -0700 +Message-ID: <87sika7dla.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 02 Sep 2014 06:15:28 -0000 + +Austin Clements writes: + +> 48db8c8 introduced a disagreement between when +> notmuch_database_needs_upgrade returned TRUE and when +> notmuch_database_upgrade actually performed an upgrade. As a result, +> if a database had a version less than 3, but no new features were +> required, notmuch new would call notmuch_database_upgrade to perform +> an upgrade, but notmuch_database_upgrade would return immediately +> without updating the database version. Hence, the next notmuch new +> would do the same, and so on. +> + +Thanks for the quick fix. + +pushed, + +d