From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Thu, 31 Dec 2015 13:46:50 +0000 (+0200)
Subject: Re: [PATCH 0/2] nmbug-status: h1 title and unbalanced <p> fixups to default templates
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b71564d198493912dffd0e17e70abc49af4449c0;p=notmuch-archives.git

Re: [PATCH 0/2] nmbug-status: h1 title and unbalanced <p> fixups to default templates
---

diff --git a/74/2a09ef229de75ba221993611505bd83b733e36 b/74/2a09ef229de75ba221993611505bd83b733e36
new file mode 100644
index 000000000..1460939c0
--- /dev/null
+++ b/74/2a09ef229de75ba221993611505bd83b733e36
@@ -0,0 +1,89 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 4319B6DE1B00
+ for <notmuch@notmuchmail.org>; Thu, 31 Dec 2015 05:46:36 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.682
+X-Spam-Level: 
+X-Spam-Status: No, score=0.682 tagged_above=-999 required=5 tests=[AWL=0.030, 
+ SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id XRFxOGlOUXlf for <notmuch@notmuchmail.org>;
+ Thu, 31 Dec 2015 05:46:34 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id BA0A36DE1AEB
+ for <notmuch@notmuchmail.org>; Thu, 31 Dec 2015 05:46:33 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id C580910008C;
+ Thu, 31 Dec 2015 15:46:50 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: "W. Trevor King" <wking@tremily.us>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 0/2] nmbug-status: h1 title and unbalanced <p> fixups to
+ default templates
+In-Reply-To: <cover.1451509249.git.wking@tremily.us>
+References: <cover.1451509249.git.wking@tremily.us>
+User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Thu, 31 Dec 2015 15:46:50 +0200
+Message-ID: <m21ta2d92t.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Thu, 31 Dec 2015 13:46:36 -0000
+
+On Wed, Dec 30 2015, "W. Trevor King" <wking@tremily.us> wrote:
+
+> Polishing the templates a bit.  Details in the individual patches.
+
+This series LGTM. (html) tidy complains about imo irrelevant things -- or
+I just did not know how to use it correctly -- as `| tidy -eq`.
+
+>
+> Cheers,
+> Trevor
+
+Tomi
+
+
+PS: it was a bit difficult to test, had to resort to reading sources
+and experment with some git commands. So (i.e. Note to self):
+
+$ git --git-dir ./.nmbug cat-file -p remotes/origin/config:status-config.json > ~/tmp/nmbug...
+$ PYTHONPATH=$PWD/bindings/python python2.7 devel/nmbug/nmbug-status --config ~/tmp/nmbug...
+
+(and | tidy -eq )
+
+
+>
+> W. Trevor King (2):
+>   nmbug-status: Adjust headers to start with h1
+>   nmbug-status: Fix unbalanced <p> tags in default header/footer
+>
+>  devel/nmbug/nmbug-status | 7 ++++---
+>  1 file changed, 4 insertions(+), 3 deletions(-)
+>
+> -- 
+> 2.1.0.60.g85f0837
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> https://notmuchmail.org/mailman/listinfo/notmuch