From: Jani Nikula Date: Sun, 25 May 2014 09:17:46 +0000 (+0300) Subject: Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b6a6b94971d28a0d00ea78e19d30a4f56a1a4343;p=notmuch-archives.git Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps --- diff --git a/f6/42931c42326198e9bcf2c19b7d28e1e5f6bccb b/f6/42931c42326198e9bcf2c19b7d28e1e5f6bccb new file mode 100644 index 000000000..a4bca9c20 --- /dev/null +++ b/f6/42931c42326198e9bcf2c19b7d28e1e5f6bccb @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 781E3431FC9 + for ; Sun, 25 May 2014 02:17:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id iEA+00G5pSAO for ; + Sun, 25 May 2014 02:17:51 -0700 (PDT) +Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com + [74.125.82.51]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + C4A23431FC7 for ; Sun, 25 May 2014 02:17:50 -0700 + (PDT) +Received: by mail-wg0-f51.google.com with SMTP id x13so6676943wgg.22 + for ; Sun, 25 May 2014 02:17:48 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=4vs1JhQQiqXa7itHue73B3SmSEmntzfWN10Lb2kz/Gc=; + b=Vo0kPE3YXw5JKPrhzeQzF5iZ6Nr5EFhv9VrjNiK8qu/okr9JeAgizFitK9g8OYUnFH + 9rBUg+3aqLOqWzLpczEDvC3lEL9skB5rwxHSaKRC4Wcq+vxYL9pBLUnL7BH8YAwXFAOK + OtyVWjfdOTHO3I1wwerzlNgVMv40pAfNL84wvZVGu+ZWO5ymngHoMIVeCyU9TE9INVem + IoycHPPb0h223OuJwuH75gE3xovfZ3Xf82BRjdr+8eZWdi/zMxGEnb2fWwm6WmPmj88m + 1HWuAi2C4K2c3dg6O/q492CpclQk2tzC0BF/WASxOFqBxHw2LosgXo0fsBVNqgeQ381f + 1xbg== +X-Gm-Message-State: + ALoCoQm9fpJw1g5HpKGZOgWE8mxzvd6szkdW4UJ7UCLePqWyUWl5vAVapOmbUXbpgLXi1WoL2ym5 +X-Received: by 10.180.74.203 with SMTP id w11mr17294523wiv.27.1401009468518; + Sun, 25 May 2014 02:17:48 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. + [88.195.111.91]) by mx.google.com with ESMTPSA id + lo18sm16766367wic.1.2014.05.25.02.17.46 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sun, 25 May 2014 02:17:47 -0700 (PDT) +From: Jani Nikula +To: Felipe Contreras , + Felipe Contreras , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps +In-Reply-To: <5381a172d52b5_d72bf52fc50@nysa.notmuch> +References: <1400841267-12807-1-git-send-email-felipe.contreras@gmail.com> + <1400841267-12807-2-git-send-email-felipe.contreras@gmail.com> + <87wqdai92o.fsf@nikula.org> + <5381a172d52b5_d72bf52fc50@nysa.notmuch> +User-Agent: Notmuch/0.18~rc0+2~gbc64cdc (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 25 May 2014 12:17:46 +0300 +Message-ID: <87r43ii5dx.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: Ali Polatel +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 25 May 2014 09:17:56 -0000 + +On Sun, 25 May 2014, Felipe Contreras wrote: +> Jani Nikula wrote: +>> On Fri, 23 May 2014, Felipe Contreras wrote: +>> > They don't affect the global build. +>> +>> They do. +> +> They don't. + +Your patch, your commit message, please explain *why* you think they +wouldn't or shouldn't affect the global build. Just to mention one +thing, why someone modifying cflags in sub makefiles shouldn't cause +rebuild? + + +BR, +Jani.