From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Tue, 28 Jan 2014 11:13:06 +0000 (+0200)
Subject: Re: [PATCH v3] build: write VERSION file containing $(VERSION) string
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b69fdc555134e3d9c6e5530735ef16663af93c0b;p=notmuch-archives.git

Re: [PATCH v3] build: write VERSION file containing $(VERSION) string
---

diff --git a/a6/f45ecb17354213e1d9d5321154c104854eb27e b/a6/f45ecb17354213e1d9d5321154c104854eb27e
new file mode 100644
index 000000000..c0f6623f1
--- /dev/null
+++ b/a6/f45ecb17354213e1d9d5321154c104854eb27e
@@ -0,0 +1,82 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1B093431FBF
+	for <notmuch@notmuchmail.org>; Tue, 28 Jan 2014 03:13:26 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id slIproWt2nqB for <notmuch@notmuchmail.org>;
+	Tue, 28 Jan 2014 03:13:16 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 7EB15431FBD
+	for <notmuch@notmuchmail.org>; Tue, 28 Jan 2014 03:13:16 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 9BD52100051;
+	Tue, 28 Jan 2014 13:13:06 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v3] build: write VERSION file containing $(VERSION) string
+In-Reply-To: <87zjmgkgxm.fsf@zancas.localnet>
+References: <1390858998-9846-1-git-send-email-tomi.ollila@iki.fi>
+	<1390859290-10112-1-git-send-email-tomi.ollila@iki.fi>
+	<87zjmgkgxm.fsf@zancas.localnet>
+User-Agent: Notmuch/0.17+55~g4397960 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Tue, 28 Jan 2014 13:13:06 +0200
+Message-ID: <m261p4mkal.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 28 Jan 2014 11:13:26 -0000
+
+On Tue, Jan 28 2014, David Bremner <david@tethera.net> wrote:
+
+> Tomi Ollila <tomi.ollila@iki.fi> writes:
+>
+>> +VERSION:=$(shell gv=`exec git describe --match '[0-9.]*'|sed -e s/_/~/ -e s/-/+/ -e s/-/~/`; test -f VERSION || touch VERSION; read fv < VERSION; test x"$$fv" = x"$$gv" || echo "$$gv" > VERSION; echo "$$gv")
+>
+> does this need to be one line long? It's a bit scary.
+
+Probably not -- I realized after sending v3 I could have split that
+(among one other problem...)
+
+>
+>> +# this file may already have been updated.
+>> +VERSION: version
+>> +	echo $(VERSION) > version
+>
+> I'd prefer the build process does not change any version controlled
+> file. It should be source, or generated, but not both. did  you mean to
+> write to VERSION here?
+
+I sure meant to. actually echo $(VERSION) > $@
+
+>
+> d
+>
+
+Tnx for the review...
+
+
+Tomi