From: Mark Walters Date: Tue, 25 Feb 2014 14:23:21 +0000 (+0000) Subject: Re: Sphinx/docutils conversion v4 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b5bed36c5d1d3a62180353ba731e869d80ef6ea9;p=notmuch-archives.git Re: Sphinx/docutils conversion v4 --- diff --git a/8d/c2e5ff82622c4cd3517dde07c871304712751b b/8d/c2e5ff82622c4cd3517dde07c871304712751b new file mode 100644 index 000000000..6d23d988b --- /dev/null +++ b/8d/c2e5ff82622c4cd3517dde07c871304712751b @@ -0,0 +1,105 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1C3A9429E43 + for ; Tue, 25 Feb 2014 06:23:37 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 20jbsJLP-K21 for ; + Tue, 25 Feb 2014 06:23:33 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 082FD429E3F + for ; Tue, 25 Feb 2014 06:23:33 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1WIIup-0001kM-EN; Tue, 25 Feb 2014 14:23:26 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1WIIup-0007kL-39; Tue, 25 Feb 2014 14:23:23 +0000 +From: Mark Walters +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: Sphinx/docutils conversion v4 +In-Reply-To: <1393329181-17404-1-git-send-email-david@tethera.net> +References: <1393329181-17404-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.15.2+562~g339f306 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 25 Feb 2014 14:23:21 +0000 +Message-ID: <87fvn746g6.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 968f2939372d59f6d47c9213ef39ed69 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 25 Feb 2014 14:23:37 -0000 + + +This version LGTM with one small comment mentioned on irc (and already +fixed). + +The small comment is that the --format option for dump and restore is in +bold and not in [ ] so it looks required. + +Aside from that +1 from me. + +Best wishes + +Mark + + +On Tue, 25 Feb 2014, David Bremner wrote: +> I think I got most of the formatting problems in this round. There +> are a few places where blank lines could be added; for technical +> reasons I'd prefer to leave that tidying to followup patches. +> +> I didn't do anything about python style/portability issues yet, or +> integrate the new docs completely into the notmuch build system. +> +> To test you need sphinx >= v1.0 or rst2man from docutils (not sure of version) +> +> % make man # sphinx based, ends up in doc/_build/man +> +> % make rst2man # ends up in doc/rst2man +> +> Currently the latter ends in a man hierarchy, the former not. Not sure +> if this matters. +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch