From: Robin H. Johnson Date: Fri, 13 Jan 2012 20:30:47 +0000 (-0800) Subject: Prior to commit a141d715, CMD_NOINSTALL had no default set, but most of the usages... X-Git-Tag: v3.4.23~4 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b49f1f377db6482aeb4f0a0a717f54632319ded9;p=genkernel.git Prior to commit a141d715, CMD_NOINSTALL had no default set, but most of the usages were of the form "! isTrue ${CMD_NOINSTALL}", which on an unset value, came out as false. These were replaced by "isTrue ${CMD_INSTALL}", but my analysis of the needed default value was wrong, and was set to false instead of true. Signed-off-by: Robin H. Johnson --- diff --git a/ChangeLog b/ChangeLog index 8b3c23e..e1a5545 100644 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,13 @@ # Distributed under the GPL v2 # $Id$ + 13 Jan 2012; Robin H. Johnson gen_determineargs.sh: + Prior to commit a141d715, CMD_NOINSTALL had no default set, but most of the + usages were of the form "! isTrue ${CMD_NOINSTALL}", which on an unset value, + came out as false. These were replaced by "isTrue ${CMD_INSTALL}", but my + analysis of the needed default value was wrong, and was set to false instead + of true. + 13 Jan 2012; Sebastian Pipping genkernel.conf: Replace "# FOO=bar" by "#FOO=bar" in genkernel.conf to (1) distinguish commented-out options from their explanatory comments and (2) to return diff --git a/gen_determineargs.sh b/gen_determineargs.sh index cd91a27..66f7ee1 100755 --- a/gen_determineargs.sh +++ b/gen_determineargs.sh @@ -128,7 +128,7 @@ determine_real_args() { set_config_with_override BOOL KEYMAP CMD_KEYMAP "yes" set_config_with_override BOOL DOKEYMAPAUTO CMD_DOKEYMAPAUTO set_config_with_override STRING BUSYBOX_CONFIG CMD_BUSYBOX_CONFIG - set_config_with_override BOOL INSTALL CMD_INSTALL "no" + set_config_with_override BOOL INSTALL CMD_INSTALL "yes" BOOTDIR=`arch_replace "${BOOTDIR}"` BOOTDIR=${BOOTDIR%/} # Remove any trailing slash