From: Alexis Ballier Date: Sat, 26 Sep 2015 09:50:01 +0000 (+0200) Subject: dev-ros/rviz: Fix build of python bindings if rviz was not previously installed.... X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b3f1ee6b4589cfaad2e2224517aab46926d1da72;p=gentoo.git dev-ros/rviz: Fix build of python bindings if rviz was not previously installed. Bug #561480 by Eric Timmons. Package-Manager: portage-2.2.22 --- diff --git a/dev-ros/rviz/files/libdir.patch b/dev-ros/rviz/files/libdir.patch new file mode 100644 index 000000000000..9044dedc641d --- /dev/null +++ b/dev-ros/rviz/files/libdir.patch @@ -0,0 +1,26 @@ +https://github.com/ros-visualization/rviz/pull/922 + +commit 2f93b132a63e25e3cece330ebaf16de7a8aa9517 +Author: Alexis Ballier +Date: Sat Sep 26 11:39:39 2015 +0200 + + python_bindings: sip: Use CATKIN_PACKAGE_LIB_DESTINATION instead of hardcoded lib. + + Fixes build with libdir != lib. + https://bugs.gentoo.org/show_bug.cgi?id=561480 + +diff --git a/src/python_bindings/sip/CMakeLists.txt b/src/python_bindings/sip/CMakeLists.txt +index 6b0c939..c91a6be 100644 +--- a/src/python_bindings/sip/CMakeLists.txt ++++ b/src/python_bindings/sip/CMakeLists.txt +@@ -42,8 +42,8 @@ include(${python_qt_binding_EXTRAS_DIR}/sip_helper.cmake) + # maintain context for different named target + set(rviz_sip_INCLUDE_DIRS ${rviz_INCLUDE_DIRS} "${PROJECT_SOURCE_DIR}/src" ${catkin_INCLUDE_DIRS}) + set(rviz_sip_LIBRARIES ${rviz_LIBRARIES} ${PROJECT_NAME}) +-set(rviz_sip_LIBRARY_DIRS ${rviz_LIBRARY_DIRS} ${CATKIN_DEVEL_PREFIX}/lib) +-set(rviz_sip_LDFLAGS_OTHER ${rviz_LDFLAGS_OTHER} -Wl,-rpath,\\"${CATKIN_DEVEL_PREFIX}/lib\\") ++set(rviz_sip_LIBRARY_DIRS ${rviz_LIBRARY_DIRS} ${CATKIN_DEVEL_PREFIX}/${CATKIN_PACKAGE_LIB_DESTINATION}) ++set(rviz_sip_LDFLAGS_OTHER ${rviz_LDFLAGS_OTHER} -Wl,-rpath,\\"${CATKIN_DEVEL_PREFIX}/${CATKIN_PACKAGE_LIB_DESTINATION}\\") + + if(sip_helper_FOUND) + list(APPEND rviz_BINDINGS "sip") diff --git a/dev-ros/rviz/rviz-1.11.9.ebuild b/dev-ros/rviz/rviz-1.11.9.ebuild index 0bb062de3654..c801bb968c32 100644 --- a/dev-ros/rviz/rviz-1.11.9.ebuild +++ b/dev-ros/rviz/rviz-1.11.9.ebuild @@ -58,3 +58,5 @@ DEPEND="${RDEPEND} dev-ros/rostest[${PYTHON_USEDEP}] dev-cpp/gtest )" + +PATCHES=( "${FILESDIR}/libdir.patch" )