From: Austin Clements Date: Sat, 14 Sep 2013 20:55:09 +0000 (+2000) Subject: Re: [PATCH] emacs: bugfix unquoted symbol X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b314f21b0799ade422a2858bbff419c231de88ab;p=notmuch-archives.git Re: [PATCH] emacs: bugfix unquoted symbol --- diff --git a/0a/791fd1c4b819343ece34d463c2a8eec68ecf3f b/0a/791fd1c4b819343ece34d463c2a8eec68ecf3f new file mode 100644 index 000000000..14c92b432 --- /dev/null +++ b/0a/791fd1c4b819343ece34d463c2a8eec68ecf3f @@ -0,0 +1,112 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id EA24C431FAF + for ; Sat, 14 Sep 2013 13:55:21 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id HUUMRY-koCdn for ; + Sat, 14 Sep 2013 13:55:15 -0700 (PDT) +Received: from dmz-mailsec-scanner-4.mit.edu (dmz-mailsec-scanner-4.mit.edu + [18.9.25.15]) + by olra.theworths.org (Postfix) with ESMTP id 9D521431FAE + for ; Sat, 14 Sep 2013 13:55:15 -0700 (PDT) +X-AuditID: 1209190f-b7fa58e000000953-34-5234cd32026e +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP + id EC.DC.02387.23DC4325; Sat, 14 Sep 2013 16:55:14 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id r8EKtDt4008066; + Sat, 14 Sep 2013 16:55:14 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r8EKtBdZ016354 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Sat, 14 Sep 2013 16:55:12 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1VKws1-0003ht-RY; Sat, 14 Sep 2013 16:55:10 -0400 +Date: Sat, 14 Sep 2013 16:55:09 -0400 +From: Austin Clements +To: Mark Walters +Subject: Re: [PATCH] emacs: bugfix unquoted symbol +Message-ID: <20130914205508.GW1426@mit.edu> +References: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT1zU6axJk8Kvf2GL1XB6L6zdnMjsw + eeycdZfd49mqW8wBTFFcNimpOZllqUX6dglcGbP7jrIUTOKs2HSpg6mBcRp7FyMHh4SAicTh + bzZdjJxAppjEhXvr2UBsIYF9jBJ3dxt3MXIB2RsZJWa9O80G4ZxmkljdeIkdwlnCKHFrwU1W + kBYWAVWJSz8esoPYbAIaEtv2L2cEsUUEdCRuH1oAFmcWkJb49ruZCcQWFjCS2LxtGVicV0Bb + 4syHo8wQqz0luk69YIWIC0qcnPmEBaJXS+LGv5dMIFeDzFn+jwMkzCngJdH7pA/salEBFYkp + J7exTWAUmoWkexaS7lkI3QsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpmujlZpbopaaUbmIE + hTSnJP8Oxm8HlQ4xCnAwKvHwfvA1DhJiTSwrrsw9xCjJwaQkynvjtEmQEF9SfkplRmJxRnxR + aU5q8SFGCQ5mJRFeJzGgHG9KYmVValE+TEqag0VJnHe9k36QkEB6YklqdmpqQWoRTFaGg0NJ + glfiDFCjYFFqempFWmZOCUKaiYMTZDgP0HA7kBre4oLE3OLMdIj8KUZFKXFeGZCEAEgiozQP + rheWcl4xigO9IsxrA1LFA0xXcN2vgAYzAQ3evNsIZHBJIkJKqoGx6OZn3tVH5c67/Zv25tGM + xYbqF2ZqvtfsLak1eBDZFjDh6rvz1YfczhcXOHTpFMR7mwukb1b9t7f9+hKHqx8C3eqd3j+Q + zA++cCJhg06+uWRXH4/5uZY2i6BrZsu2xq7KLrlz4/Vh1ZK7sbn3XTk2pQkE3nwclGleFbWV + 6d3nmYKxD764PA5RYinOSDTUYi4qTgQAFaWigBQDAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 14 Sep 2013 20:55:22 -0000 + +Definitely LGTM. + +Quoth Mark Walters on Sep 14 at 9:17 pm: +> In the recent changes for search order handling the default-value of +> notmuch-search-oldest-first was used. However, default-value needs a +> symbol so the symbol-name needs to be quoted. +> +> This missing quote was causing strange sort-orders in some cases. +> --- +> +> I think this is clearly correct (and what was intended) and it seems +> to work as expected. +> +> Best wishes +> +> Mark +> +> +> +> +> emacs/notmuch.el | 2 +- +> 1 files changed, 1 insertions(+), 1 deletions(-) +> +> diff --git a/emacs/notmuch.el b/emacs/notmuch.el +> index 4de6229..0ff248b 100644 +> --- a/emacs/notmuch.el +> +++ b/emacs/notmuch.el +> @@ -888,7 +888,7 @@ the configured default sort order." +> nil +> ;; Use the default search order (if we're doing a search from a +> ;; search buffer, ignore any buffer-local overrides) +> - (default-value notmuch-search-oldest-first))) +> + (default-value 'notmuch-search-oldest-first))) +> +> (let* ((query (or query (notmuch-read-query "Notmuch search: "))) +> (buffer (get-buffer-create (notmuch-search-buffer-title query))))