From: Tomi Ollila Date: Tue, 8 Jul 2014 08:56:55 +0000 (+0300) Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b2e3642a9e190d07bb9f191590c07f7ea75bb5ea;p=notmuch-archives.git Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. --- diff --git a/c0/a19f4cea692662536f87086b6a7b85c82ea369 b/c0/a19f4cea692662536f87086b6a7b85c82ea369 new file mode 100644 index 000000000..75484c0ef --- /dev/null +++ b/c0/a19f4cea692662536f87086b6a7b85c82ea369 @@ -0,0 +1,106 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1790B431FBC + for ; Tue, 8 Jul 2014 01:57:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nXDehPoTKr87 for ; + Tue, 8 Jul 2014 01:57:02 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id BF414431FAF + for ; Tue, 8 Jul 2014 01:57:02 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 9504710008F; + Tue, 8 Jul 2014 11:56:55 +0300 (EEST) +From: Tomi Ollila +To: Sebastian Lipp , Karl Fogel +Subject: Re: [PATCH] emacs: add missing paren to fix defun + in notmuch-address.el. +In-Reply-To: + <87bnt2dy0b.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> +References: <87wqsfik5l.fsf@floss.red-bean.com> + <87mwtah2hd.fsf@zancas.localnet> + <877gkeau42.fsf@floss.red-bean.com> + <8738v1jtzc.fsf@nikula.org> + <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov> + + <87vc7vgbym.fsf@zancas.localnet> + + <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> + <87oax6vt4u.fsf@ktab.red-bean.com> + <87bnt2dy0b.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> +User-Agent: Notmuch/0.18.1+25~gdaf4b6f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 08 Jul 2014 08:57:11 -0000 + +On Sun, Jul 06 2014, Sebastian Lipp wrote: + +> Karl Fogel writes: +>> Sebastian Lipp writes: +>>>diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el +>>>index fa65cd5..ee7b169 100644 +>>>--- a/emacs/notmuch-address.el +>>>+++ b/emacs/notmuch-address.el +>>>@@ -113,6 +113,59 @@ to know how address selection is made by default." +>>> (when (notmuch-address-locate-command notmuch-address-command) +>>> (notmuch-address-message-insinuate)) +>>> +>>>+;; functions to add sender / recipients to BBDB +>>>+ +>>>+(defvar bbdb-get-addresses-headers) +>> +>> I think it's good to include an initial value (even an invalid +>> placeholder one, if the real initialization has not happened yet), and a +>> doc string. C-h f defvar RET will say more about how to do that. +> +> I hope I got that right now. (I've got no real clue of Lisp yet because +> I just recently switched to emacs partly because of notmuch. :) +> +> How about +> +> (defvar bbdb-get-addresses-headers nil +> "List of Addresses to import into bbdb") +> +> ? +> +>> (By the way, this isn't a user-customizeable variable, right? If it +>> were, then `defcustom' would be better than `defvar'.) +> +> As far as I understand it: It's not. + +someone(tm) could explain why or why-not this is defvar and not defcustom +(or wice versa) so that I don't have to spend time digging into it + +but the bbdb-* looks a bit too generic (goes deep into bbdb "namespace" +in a file not part of bbdb -package) + + +Tomi