From: David Bremner Date: Sat, 1 Jun 2013 12:36:51 +0000 (+2100) Subject: Re: [PATCH 1/2] contrib: pick: add thread based utility functions X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b1e9d4ecb24fddc6a084141b7522777952a06a4d;p=notmuch-archives.git Re: [PATCH 1/2] contrib: pick: add thread based utility functions --- diff --git a/35/f11122d585e5bc8c73844da333ec225d586917 b/35/f11122d585e5bc8c73844da333ec225d586917 new file mode 100644 index 000000000..dc17cf6e4 --- /dev/null +++ b/35/f11122d585e5bc8c73844da333ec225d586917 @@ -0,0 +1,82 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 122F5429E4F + for ; Sat, 1 Jun 2013 05:37:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ZlSbI5GFXtT5 for ; + Sat, 1 Jun 2013 05:36:56 -0700 (PDT) +Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2B17A431FDE + for ; Sat, 1 Jun 2013 05:36:56 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r51CasLs023810; + Sat, 1 Jun 2013 09:36:54 -0300 +Received: from remotemail by tesseract.cs.unb.ca with local (Exim 4.80) + (envelope-from ) + id 1Uil3G-0003yQ-9C; Sat, 01 Jun 2013 09:36:54 -0300 +Received: (nullmailer pid 12141 invoked by uid 1000); + Sat, 01 Jun 2013 12:36:52 -0000 +From: David Bremner +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] contrib: pick: add thread based utility functions +In-Reply-To: <878v30kh8p.fsf@qmul.ac.uk> +References: <1354970914-18342-1-git-send-email-markwalters1009@gmail.com> + <1354970914-18342-2-git-send-email-markwalters1009@gmail.com> + <87fvxswgff.fsf@zancas.localnet> <878v30kh8p.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.15.2+69~g360c3c8 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 01 Jun 2013 09:36:51 -0300 +Message-ID: <87ppw6ypln.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 01 Jun 2013 12:37:04 -0000 + +Mark Walters writes: +> +> David Bremner writes: +> +> +>> More importantly, in emacs 24.3 I get an infinite loop when trying to +>> evaluate the update notmuch-pick.el. +> +> I think this is just stupidity on my part: it should be a defun rather +> than a defmacro. Would you be able to test that (or I can send a new +> version if you prefer)? +> + +Yes, changing that defmacro to a defun fixes the loop. + +I load pick as follows + + (add-to-list 'load-path + (expand-file-name "~/software/upstream/notmuch/contrib/notmuch-pick")) + (require 'notmuch-pick nil t) + + +I'll need another version in any case, since it doesn't apply to master +anymore, but hold off for a review of 2/2. + +d