From: David Edmondson Date: Mon, 8 Feb 2016 17:11:36 +0000 (+0000) Subject: Re: [PATCH v4 0/7] emacs: Improve the cited message included in replies X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b1a7adb88552692875254164b80ff0d1a22b34d5;p=notmuch-archives.git Re: [PATCH v4 0/7] emacs: Improve the cited message included in replies --- diff --git a/6d/e6b9831caa25fad65e6826525b2dc6b27cef66 b/6d/e6b9831caa25fad65e6826525b2dc6b27cef66 new file mode 100644 index 000000000..f1a2edd7a --- /dev/null +++ b/6d/e6b9831caa25fad65e6826525b2dc6b27cef66 @@ -0,0 +1,139 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id D60336DE0AC2 + for ; Mon, 8 Feb 2016 09:11:44 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.008 +X-Spam-Level: +X-Spam-Status: No, score=0.008 tagged_above=-999 required=5 tests=[AWL=0.075, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652, + UNPARSEABLE_RELAY=0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id pb-IFvouXweq for ; + Mon, 8 Feb 2016 09:11:42 -0800 (PST) +Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com + [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id 2576F6DE02CE for + ; Mon, 8 Feb 2016 09:11:42 -0800 (PST) +Received: by mail-wm0-f68.google.com with SMTP id 128so16380544wmz.3 + for ; Mon, 08 Feb 2016 09:11:42 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=dme-org.20150623.gappssmtp.com; s=20150623; + h=to:subject:in-reply-to:references:from:date:message-id:mime-version + :content-type; bh=mg+EgrME11VliK1Uu4uvJL4Buu/RWT55NhHmeQoY6lQ=; + b=G8IEe5SRJ1B0KPFuPCNxCFcxtVQ+xVcpjsEIF0Uw+eQchJIpSmZ7F5y0XuTIpNBh4w + NGhRklYgUnpG55AOqYGQJ8QyShfioo9/XsVYQHbXY0OC9aUpgcOJs7LcLkOL1oW5MCb3 + K1u0g48+jGJN0/UaWKdjm1xWFtV6eZBhbb6GILQ5Rw4hE8lqKpGB+G6qe8LZxVmmkuPT + JKI9rNOS0dJw0+zvLH9k1O3db1/oeobl2Jj33fHolOrZyevimYlXjULWCQnofBvWEweN + GYTHklFYgKy4KpcJZBs72DE7yvnjGCKqcoYeJcz/Lmu/mxkc4kPZZXXyFdLlnioxxt5/ + ik4Q== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:from:date + :message-id:mime-version:content-type; + bh=mg+EgrME11VliK1Uu4uvJL4Buu/RWT55NhHmeQoY6lQ=; + b=SycIwcb8zo6JuQ0SkJaiflg5RYtL23BKyFjXzC5XqbEppNq0dSmw0CZiZY9vRBHc2R + Ic2YKPWMcwRmgfnWVHUncm97XyNCDKCaLRU5az28gz4iF6+lgfVlQPaJJvthzZtTuzWd + WooDDAwjFuzLBeUuR4/1cCqWK65om9IwZrhicZ8U5Q2+R9Fs4cJ07ObX1NCyXNYnUn8V + sj5QrX6M+rYXaZoh7j9Lvrssxn0K7LpWUIr7kNmIXXWxj9NhKv3WtelhycOdxCoQ+ATJ + UXH85VUvPYGKQgmM6uOzcjKKSu5mNBermz8C+5XYjFh6acXq48lpFlig4DPQa+W11ICR + 5Qmw== +X-Gm-Message-State: + AG10YOS9T8qMZPROzJVqs/gyoWSUV2TUnQoT2Mp3M9e3GikUeNERxaPqYjYID9gIVGKo9w== +X-Received: by 10.194.95.40 with SMTP id dh8mr3719625wjb.94.1454951499464; + Mon, 08 Feb 2016 09:11:39 -0800 (PST) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by smtp.gmail.com with ESMTPSA id x6sm30698723wje.38.2016.02.08.09.11.37 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Mon, 08 Feb 2016 09:11:37 -0800 (PST) +Received: from localhost (disaster-area.hh.sledj.net [local]) + by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 2be1cf46; + Mon, 8 Feb 2016 17:11:36 +0000 (UTC) +To: notmuch@notmuchmail.org +Subject: Re: [PATCH v4 0/7] emacs: Improve the cited message included in + replies +In-Reply-To: <1446894276-7814-1-git-send-email-markwalters1009@gmail.com> +References: <1446894276-7814-1-git-send-email-markwalters1009@gmail.com> +From: David Edmondson +Date: Mon, 08 Feb 2016 17:11:36 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 08 Feb 2016 17:11:45 -0000 + +On Sat, Nov 07 2015, Mark Walters wrote: +> This is a rebase and somewhat tweaked version of dme's series from last year +> id:1399897769-26809-1-git-send-email-dme@dme.org + +I'm a bad person to review these changes, having written some of +them. Could someone else take a look? + +> One particular motivation for this series is that it fixes a long +> standing bug we have that replying to a message with an rfc822 part +> completely omits that part. It also fixes the bug whereby we don't +> include application/octet-stream parts which are actually text/plain +> (and thus are displayed in show mode). +> +> This series makes the reply code use the same code as the show code so +> everything works as expected: the reply buffer looks essentially the +> same as the show buffer. +> +> There is one slight difference: the user might want different part +> headers displayed when replying; both because the audience is +> different (a non-notmuch using recipient) and because the buttons +> don't "work" (you can't click on them to show or view a part). +> +> Dme and I disagree on which of these we would like to see so make that +> customisable. +> +> The key change is patch 3 which switches how reply works. Also note +> that patch 2 is almost all whitespace change as the changes modify the +> indentation. +> +> Best wishes +> +> Mark +> +> +> David Edmondson (6): +> emacs/show: Re-arrange determination if a part header is necessary +> emacs/show: Accommodate the lack of part header buttons +> emacs/mua: Generate improved cited text for replies +> emacs/show: Remove the 'no-buttons option of +> `notmuch-show-insert-bodypart' +> emacs/show: Make the insertion of part headers overridable. +> emacs/mua: Let user specify which parts get a header in citations. +> +> Mark Walters (1): +> test: fix the tests for the new reply code +> +> emacs/notmuch-mua.el | 60 ++++++++++----------- +> emacs/notmuch-show.el | 141 +++++++++++++++++++++++++++++++------------------- +> test/T310-emacs.sh | 32 ++++++++++++ +> test/test-lib.el | 4 ++ +> 4 files changed, 155 insertions(+), 82 deletions(-) +> +> -- +> 2.1.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> https://notmuchmail.org/mailman/listinfo/notmuch