From: Simon Hausmann Date: Sun, 20 May 2007 21:52:51 +0000 (+0200) Subject: Another (potentially life-saving) idea for submit --direct X-Git-Tag: v1.5.3-rc0~65^2^2~84 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b1561ee25628c074b3afac738ead387181d3b311;p=git.git Another (potentially life-saving) idea for submit --direct Signed-off-by: Simon Hausmann --- diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 index 92522417c..5055f3214 100755 --- a/contrib/fast-import/git-p4 +++ b/contrib/fast-import/git-p4 @@ -10,6 +10,12 @@ # TODO: * implement git-p4 rollback for debugging # to roll back all p4 remote branches to a commit older or equal to # the specified change. +# * for git-p4 submit --direct it would be nice to still create a +# git commit without updating HEAD before submitting to perforce. +# With the commit sha1 printed (or recoded in a .git/foo file?) +# it's possible to recover if anything goes wrong instead of potentially +# loosing a change entirely because it was never comitted to git and +# the p4 submit failed (or resulted in lots of conflicts, etc.) # import optparse, sys, os, marshal, popen2, subprocess, shelve