From: David Bremner <david@tethera.net>
Date: Fri, 19 Sep 2014 19:27:14 +0000 (+0200)
Subject: Re: [PATCH 1/3] cli: add support for parsing multiple keyword arguments
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b1081d394ac57373808bfb1695b9bf611a8361f4;p=notmuch-archives.git

Re: [PATCH 1/3] cli: add support for parsing multiple keyword arguments
---

diff --git a/d2/cf055a8a609a122d592ed23895350cf4d9ecfb b/d2/cf055a8a609a122d592ed23895350cf4d9ecfb
new file mode 100644
index 000000000..fe82141f8
--- /dev/null
+++ b/d2/cf055a8a609a122d592ed23895350cf4d9ecfb
@@ -0,0 +1,63 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 046ED431FBC
+	for <notmuch@notmuchmail.org>; Fri, 19 Sep 2014 12:27:26 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id OKoBCbLBj9Kn for <notmuch@notmuchmail.org>;
+	Fri, 19 Sep 2014 12:27:22 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 21645431FAE
+	for <notmuch@notmuchmail.org>; Fri, 19 Sep 2014 12:27:22 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1XV3pw-00073h-2d; Fri, 19 Sep 2014 16:27:20 -0300
+Received: (nullmailer pid 3928 invoked by uid 1000); Fri, 19 Sep 2014
+	19:27:14 -0000
+From: David Bremner <david@tethera.net>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/3] cli: add support for parsing multiple keyword
+	arguments
+In-Reply-To: <1410008010-3770-1-git-send-email-jani@nikula.org>
+References: <1410008010-3770-1-git-send-email-jani@nikula.org>
+User-Agent: Notmuch/0.18.1+97~g56c48dc (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Fri, 19 Sep 2014 21:27:14 +0200
+Message-ID: <87mw9vbect.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 19 Sep 2014 19:27:26 -0000
+
+Jani Nikula <jani@nikula.org> writes:
+
+> This allows having multiple --foo=bar --foo=baz options on the command
+> line, with the corresponding values OR'd together.
+> ---
+
+This looks OK. In hindsight I guess we could have had only keyword_flags
+from the beginning, but I guess that would be pretty intrusive to change
+at this point.
+
+d