From: David Bremner <david@tethera.net>
Date: Sun, 30 Mar 2014 11:03:16 +0000 (+2100)
Subject: Re: [Patch v2 2/3] util: add gzreadline
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b02a39925e489887e1d63d602029ba8362c8bd73;p=notmuch-archives.git

Re: [Patch v2 2/3] util: add gzreadline
---

diff --git a/f5/a1f3fae8535e255807115f7f9107ce2396b7ba b/f5/a1f3fae8535e255807115f7f9107ce2396b7ba
new file mode 100644
index 000000000..24fef3dda
--- /dev/null
+++ b/f5/a1f3fae8535e255807115f7f9107ce2396b7ba
@@ -0,0 +1,63 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id AC2C9431FBC
+	for <notmuch@notmuchmail.org>; Sun, 30 Mar 2014 04:03:32 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id EyR6TFQDX-yu for <notmuch@notmuchmail.org>;
+	Sun, 30 Mar 2014 04:03:27 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 7BB42431FB6
+	for <notmuch@notmuchmail.org>; Sun, 30 Mar 2014 04:03:27 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1WUDWK-0002rp-FS; Sun, 30 Mar 2014 08:03:20 -0300
+Received: (nullmailer pid 27054 invoked by uid 1000); Sun, 30 Mar 2014
+	11:03:16 -0000
+From: David Bremner <david@tethera.net>
+To: notmuch@notmuchmail.org
+Subject: Re: [Patch v2 2/3] util: add gzreadline
+In-Reply-To: <1396116992-29640-3-git-send-email-david@tethera.net>
+References: <1396100785-8744-1-git-send-email-david@tethera.net>
+	<1396116992-29640-1-git-send-email-david@tethera.net>
+	<1396116992-29640-3-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.17+150~g2743557 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sun, 30 Mar 2014 08:03:16 -0300
+Message-ID: <87a9c8dk3v.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 30 Mar 2014 11:03:32 -0000
+
+David Bremner <david@tethera.net> writes:
+
+
+> +	if (!gzgets (stream, buf + offset, len))
+> +	    return -1;
+
+I did find one bug by setting the initial line size to 2. This should
+read "len - offset".
+
+