From: Zac Medico <zmedico@gentoo.org>
Date: Fri, 11 Jan 2008 09:27:38 +0000 (-0000)
Subject: Add a new "ebuild.autotools" check for when ebuilds call
X-Git-Tag: v2.2_pre1~57
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=af2175f3af162eb903b997aec528130b4b56bb6b;p=portage.git

Add a new "ebuild.autotools" check for when ebuilds call
 autotools directly instead of using autotools.eclass.
Thanks to Betelgeuse for the initial patch.

svn path=/main/trunk/; revision=9179
---

diff --git a/bin/repoman b/bin/repoman
index 51fc8a395..3cb2b68ef 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -298,6 +298,7 @@ qahelp={
 	"ebuild.majorsyn":"This ebuild has a major syntax error that may cause the ebuild to fail partially or fully",
 	"ebuild.minorsyn":"This ebuild has a minor syntax error that contravenes gentoo coding style",
 	"ebuild.badheader":"This ebuild has a malformed header",
+	"ebuild.autotools":"Ebuild calls autotools directly instead of using autotools.eclass",
 	"metadata.missing":"Missing metadata.xml files",
 	"metadata.bad":"Bad metadata.xml files",
 	"virtual.versioned":"PROVIDE contains virtuals with versions",
@@ -315,6 +316,7 @@ qawarnings=[
 "ebuild.notadded",
 "ebuild.nostable",
 "ebuild.allmasked",
+"ebuild.autotools",
 "ebuild.nesteddie",
 "desktop.invalid",
 "digest.assumed",
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index 916003e7e..b4f1b016e 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -178,11 +178,25 @@ class EbuildUselessCdS(LineCheck):
 		elif self.method_re.match(line):
 			self.check_next_line = True
 
+class Autotools(LineCheck):
+	"""Check for direct calls to autotools"""
+	repoman_check_name = 'ebuild.autotools'
+	re = re.compile(r'^[^#]*([^e]|^)(autoconf|automake|aclocal|libtoolize)')
+
+	def check(self, num, line):
+		"""Run the check on line and return error if there is one"""
+		m = self.re.match(line)
+		if m is not None:
+			return ("Direct calls to '%s'" % m.group(2)) + \
+				" instead of using autotools.eclass on line: %d"
+
+_constant_checks = tuple((c() for c in (Autotools,
+	EbuildWhitespace, EbuildQuote,
+	EbuildAssignment, EbuildUselessDodoc,
+	EbuildUselessCdS, EbuildNestedDie)))
+
 def run_checks(contents, st_mtime):
-	checks = []
-	for c in (EbuildWhitespace, EbuildQuote, EbuildAssignment,
-			EbuildUselessDodoc, EbuildUselessCdS, EbuildNestedDie):
-		checks.append(c())
+	checks = list(_constant_checks)
 	checks.append(EbuildHeader(st_mtime))
 	for num, line in enumerate(contents):
 		for lc in checks: