From: Russ Allbery <rra@stanford.edu>
Date: Sun, 8 Oct 2006 03:22:48 +0000 (+0000)
Subject: Initialize buffer before calling res_ninit
X-Git-Tag: krb5-1.6-alpha1~84
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ad8951bc9b574ea81f25eb595cd51251140f8fc9;p=krb5.git

Initialize buffer before calling res_ninit

Per Paul Vixie: It is necessary to zero out the statbuf before calling
res_ninit(), or else res_vinit() will call res_nclose() and res_ndestroy()
with stack trash as a statbuf, and they will call free() with stack trash,
and programs will dump core.

Ticket: new
Component: krb5-libs
Version_Reported: 1.5.1
Target_Version: 1.5.2
Tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@18669 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/krb5/os/dnsglue.c b/src/lib/krb5/os/dnsglue.c
index ef8b08783..7a6583ca0 100644
--- a/src/lib/krb5/os/dnsglue.c
+++ b/src/lib/krb5/os/dnsglue.c
@@ -100,6 +100,7 @@ krb5int_dns_init(struct krb5int_dns_state **dsp,
 #endif
 
 #if USE_RES_NINIT
+    memset(&statbuf, 0, sizeof(statbuf));
     ret = res_ninit(&statbuf);
 #else
     ret = res_init();