From: Austin Clements Date: Tue, 12 Nov 2013 19:39:52 +0000 (+1900) Subject: Re: [PATCH] notmuch: Add "maildir:" search option X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ad59828c5c46de23313c1fe0aefa8fea33b9a9b9;p=notmuch-archives.git Re: [PATCH] notmuch: Add "maildir:" search option --- diff --git a/4e/6813a5e39039ec1307aa6ade1a751a5aadf862 b/4e/6813a5e39039ec1307aa6ade1a751a5aadf862 new file mode 100644 index 000000000..eb8de71b8 --- /dev/null +++ b/4e/6813a5e39039ec1307aa6ade1a751a5aadf862 @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A4D14431FD7 + for ; Tue, 12 Nov 2013 11:40:03 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id xOuby75+TVPE for ; + Tue, 12 Nov 2013 11:39:56 -0800 (PST) +Received: from dmz-mailsec-scanner-1.mit.edu (dmz-mailsec-scanner-1.mit.edu + [18.9.25.12]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 077B6431FD2 + for ; Tue, 12 Nov 2013 11:39:55 -0800 (PST) +X-AuditID: 1209190c-b7f7f6d000000bbd-31-5282840ba95a +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + (using TLS with cipher AES256-SHA (256/256 bits)) + (Client did not present a certificate) + by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP + id A9.08.03005.B0482825; Tue, 12 Nov 2013 14:39:55 -0500 (EST) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id rACJdrBe001174; + Tue, 12 Nov 2013 14:39:54 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id rACJdqxH004710 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Tue, 12 Nov 2013 14:39:53 -0500 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1VgJoW-000672-5s; Tue, 12 Nov 2013 14:39:52 -0500 +From: Austin Clements +To: Peter Zijlstra , notmuch@notmuchmail.org +Subject: Re: [PATCH] notmuch: Add "maildir:" search option +In-Reply-To: <87mwl94dte.fsf@awakening.csail.mit.edu> +References: <20131112155637.GA16796@laptop.programming.kicks-ass.net> + <87mwl94dte.fsf@awakening.csail.mit.edu> +User-Agent: Notmuch/0.16+154~g96c0ce2 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Tue, 12 Nov 2013 14:39:52 -0500 +Message-ID: <87k3gd4dfb.fsf@awakening.csail.mit.edu> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsUixG6nosvd0hRksOIfv8X1mzOZLY73HmBy + YPLYvELL49mqW8wBTFFcNimpOZllqUX6dglcGUtXnWQr2MBRcfvID8YGxg9sXYycHBICJhKd + Bw8zQthiEhfurQeKc3EICcxmkljSNp8ZwtnIKNH7/g6Uc5pJYt/KBrAWIYEljBJXnkiC2GwC + +hIr1k5iBbFFBJwk7n6aCmRzcAgLWEns35UEYnIKmEqsmFUA0ZkncbD/OROILSoQLzFt4U5m + EJtFQFXi6cQmRpByXpDj1oKV8AoISpyc+YQFxGYW0JK48e8l0wRGgVlIUrOQpBYwMq1ilE3J + rdLNTczMKU5N1i1OTszLSy3SNdTLzSzRS00p3cQICkVOSZ4djG8OKh1iFOBgVOLhfRDZFCTE + mlhWXJl7iFGSg0lJlNe4DijEl5SfUpmRWJwRX1Sak1p8iFGCg1lJhNehFijHm5JYWZValA+T + kuZgURLnvclhHyQkkJ5YkpqdmlqQWgSTleHgUJLgZaoHahQsSk1PrUjLzClBSDNxcIIM5wEa + XtoIMry4IDG3ODMdIn+KUVFKnFetCSghAJLIKM2D64WlileM4kCvCPPmgqzgAaYZuO5XQIOZ + gAZbFIMNLklESEk1MJbPU/dn32N7q9pyHdPelw5aCbrGk0LXX/wgtvuBd9y3aR2Pc7+s2PV8 + kr3npMA53RopvYnF9z6875F1/MP60tXWOt5F59lL9SaGKJfKz0EnYz6oHbBQydkZLbOv4ZDJ + 9Pm68wK+Btc0LNTZe8HvSMa9XivX2oK9djJNvEt+bJg66TITO/eWz0osxRmJhlrMRcWJAJ3U + kWHwAgAA +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 12 Nov 2013 19:40:03 -0000 + +On Tue, 12 Nov 2013, Austin Clements wrote: +> I think this is a great idea. Personally I think this is how folder: +> should work. I find the semantics of folder: to be useless except where +> they happen to coincide with the boolean semantics used here. +> Unfortunately, changing folder: would require versioning the database, +> which we have only primordial support for right now. +> +> Various comments below, though nothing major. Of course, we'd also need +> some tests and man page updates for this. + +Sorry, one important thing I missed: this doesn't correctly handle when +file names are removed from a message +(_notmuch_message_remove_filename). Probably the simplest thing would +be to follow the template for how folder: works by first removing *all* +folder terms and then adding back the still-valid ones. (Unfortunately, +just removing the term for the removed filename's directory won't work +because the message could have other filenames in the same directory, +though maybe you could just scan for that possibility?)