From: Ezra Peisach <epeisach@mit.edu>
Date: Thu, 14 Aug 2008 16:25:29 +0000 (+0000)
Subject: In krb5int_copy_creds_contents - if we run out of memory, do not
X-Git-Tag: krb5-1.7-alpha1~492
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ad499ad382a7fc21cec0a19236cd602b4bee7366;p=krb5.git

In krb5int_copy_creds_contents - if we run out of memory, do not
release pointer to output creds structure that is passed in by caller.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20657 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/krb5/krb/copy_creds.c b/src/lib/krb5/krb/copy_creds.c
index 9fdf9a67d..417a9a449 100644
--- a/src/lib/krb5/krb/copy_creds.c
+++ b/src/lib/krb5/krb/copy_creds.c
@@ -108,6 +108,7 @@ krb5int_copy_creds_contents(krb5_context context, const krb5_creds *incred,
  cleanclient:
     krb5_free_principal(context, tempcred->client);
  cleanlast:
-    krb5_xfree(tempcred);
+    /* Do not free tempcred - we did not allocate it - its contents are 
+       garbage - but we should not free it */
     return retval;
 }