From: David Bremner <david@tethera.net>
Date: Fri, 31 Oct 2014 16:56:36 +0000 (+0100)
Subject: Re: [PATCH] test: use LDFLAGS in test/Makefile.local
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ac9c2d12b0428c0bd46b9d7536d1eb96ad8be1ff;p=notmuch-archives.git

Re: [PATCH] test: use LDFLAGS in test/Makefile.local
---

diff --git a/82/9df47996ebb81092954ddbd894c294439778d8 b/82/9df47996ebb81092954ddbd894c294439778d8
new file mode 100644
index 000000000..7a3bcd42a
--- /dev/null
+++ b/82/9df47996ebb81092954ddbd894c294439778d8
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1C813431FC2
+	for <notmuch@notmuchmail.org>; Fri, 31 Oct 2014 09:56:56 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 1t7BncFLiR5K for <notmuch@notmuchmail.org>;
+	Fri, 31 Oct 2014 09:56:48 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 3AF54431FD6
+	for <notmuch@notmuchmail.org>; Fri, 31 Oct 2014 09:56:44 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1XkFVB-0001JL-SI; Fri, 31 Oct 2014 13:56:41 -0300
+Received: (nullmailer pid 13573 invoked by uid 1000); Fri, 31 Oct 2014
+	16:56:36 -0000
+From: David Bremner <david@tethera.net>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] test: use LDFLAGS in test/Makefile.local
+In-Reply-To: <1413817401-6058-1-git-send-email-jani@nikula.org>
+References: <1413817401-6058-1-git-send-email-jani@nikula.org>
+User-Agent: Notmuch/0.18.1+131~gdd8373f (http://notmuchmail.org) Emacs/24.4.1
+	(x86_64-pc-linux-gnu)
+Date: Fri, 31 Oct 2014 17:56:36 +0100
+Message-ID: <8738a4mb3v.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 31 Oct 2014 16:56:56 -0000
+
+Jani Nikula <jani@nikula.org> writes:
+
+> Apparently the test binaries are built with minimal LDFLAGS, only
+> adding dependency specific LDFLAGS as needed. However because some of
+> the test binaries incorporate notmuch object files, it is necessary to
+> use the same link flags as notmuch. For example user provided
+> CFLAGS/CXXFLAGS/LDFLAGS with -fsanitize=undefined fails to build the
+> test binaries if the flags differ.
+>
+> ---
+
+pushed
+
+d