From: Junio C Hamano <junkio@cox.net>
Date: Thu, 6 Jul 2006 02:44:03 +0000 (-0700)
Subject: git-reset: complain and exit upon seeing an unknown parameter.
X-Git-Tag: v1.4.2-rc1~80
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ac83aa2e1fffcb4e7560431ddc15b288dc237634;p=git.git

git-reset: complain and exit upon seeing an unknown parameter.

The check to use "rev-parse --verify" was defeated by the use of
"--default HEAD".  "git reset --hard bogus-committish" just
defaulted to reset to the HEAD without complaining.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/git-reset.sh b/git-reset.sh
index 46451d0d6..5c0224090 100755
--- a/git-reset.sh
+++ b/git-reset.sh
@@ -17,7 +17,11 @@ case "$1" in
         usage ;;
 esac
 
-rev=$(git-rev-parse --verify --default HEAD "$@") || exit
+case $# in
+0) rev=HEAD ;;
+1) rev=$(git-rev-parse --verify "$1") || exit ;;
+*) usage ;;
+esac
 rev=$(git-rev-parse --verify $rev^0) || exit
 
 # We need to remember the set of paths that _could_ be left