From: David Bremner Date: Wed, 25 May 2016 10:51:25 +0000 (+2100) Subject: [Patch v6 6/7] lib: make a global constant for query parser flags X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ab829d27a22e3e30bb3e041b5a58a0268a59ef50;p=notmuch-archives.git [Patch v6 6/7] lib: make a global constant for query parser flags --- diff --git a/e7/2dfd5d093a1b9476a4130284494ba094f0b3da b/e7/2dfd5d093a1b9476a4130284494ba094f0b3da new file mode 100644 index 000000000..5c75ab34c --- /dev/null +++ b/e7/2dfd5d093a1b9476a4130284494ba094f0b3da @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 980E86DE092C + for ; Wed, 25 May 2016 03:52:00 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.012 +X-Spam-Level: +X-Spam-Status: No, score=-0.012 tagged_above=-999 required=5 + tests=[AWL=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id J5tJMWismH6o for ; + Wed, 25 May 2016 03:51:53 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id EA17F6DE025F + for ; Wed, 25 May 2016 03:51:37 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1b5WPQ-0004UB-Jf; Wed, 25 May 2016 06:51:28 -0400 +Received: (nullmailer pid 23148 invoked by uid 1000); + Wed, 25 May 2016 10:51:31 -0000 +From: David Bremner +To: notmuch@notmuchmail.org +Subject: [Patch v6 6/7] lib: make a global constant for query parser flags +Date: Wed, 25 May 2016 07:51:25 -0300 +Message-Id: <1464173486-23032-7-git-send-email-david@tethera.net> +X-Mailer: git-send-email 2.8.1 +In-Reply-To: <1464173486-23032-1-git-send-email-david@tethera.net> +References: <1464173486-23032-1-git-send-email-david@tethera.net> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 25 May 2016 10:52:00 -0000 + +It's already kindof gross that this is hardcoded in two different +places. We will also need these later in field processors calling back +into the query parser. +--- + lib/database-private.h | 7 +++++++ + lib/query.cc | 16 ++-------------- + 2 files changed, 9 insertions(+), 14 deletions(-) + +diff --git a/lib/database-private.h b/lib/database-private.h +index e1962f4..d2990b6 100644 +--- a/lib/database-private.h ++++ b/lib/database-private.h +@@ -144,6 +144,13 @@ operator&=(_notmuch_features &a, _notmuch_features b) + return a; + } + ++#define NOTMUCH_QUERY_PARSER_FLAGS (Xapian::QueryParser::FLAG_BOOLEAN | \ ++ Xapian::QueryParser::FLAG_PHRASE | \ ++ Xapian::QueryParser::FLAG_LOVEHATE | \ ++ Xapian::QueryParser::FLAG_BOOLEAN_ANY_CASE | \ ++ Xapian::QueryParser::FLAG_WILDCARD | \ ++ Xapian::QueryParser::FLAG_PURE_NOT) ++ + struct _notmuch_database { + notmuch_bool_t exception_reported; + +diff --git a/lib/query.cc b/lib/query.cc +index 77a7926..0875b0e 100644 +--- a/lib/query.cc ++++ b/lib/query.cc +@@ -220,12 +220,6 @@ _notmuch_query_search_documents (notmuch_query_t *query, + Xapian::Query string_query, final_query, exclude_query; + Xapian::MSet mset; + Xapian::MSetIterator iterator; +- unsigned int flags = (Xapian::QueryParser::FLAG_BOOLEAN | +- Xapian::QueryParser::FLAG_PHRASE | +- Xapian::QueryParser::FLAG_LOVEHATE | +- Xapian::QueryParser::FLAG_BOOLEAN_ANY_CASE | +- Xapian::QueryParser::FLAG_WILDCARD | +- Xapian::QueryParser::FLAG_PURE_NOT); + + if (strcmp (query_string, "") == 0 || + strcmp (query_string, "*") == 0) +@@ -233,7 +227,7 @@ _notmuch_query_search_documents (notmuch_query_t *query, + final_query = mail_query; + } else { + string_query = notmuch->query_parser-> +- parse_query (query_string, flags); ++ parse_query (query_string, NOTMUCH_QUERY_PARSER_FLAGS); + final_query = Xapian::Query (Xapian::Query::OP_AND, + mail_query, string_query); + } +@@ -579,12 +573,6 @@ _notmuch_query_count_documents (notmuch_query_t *query, const char *type, unsign + type)); + Xapian::Query string_query, final_query, exclude_query; + Xapian::MSet mset; +- unsigned int flags = (Xapian::QueryParser::FLAG_BOOLEAN | +- Xapian::QueryParser::FLAG_PHRASE | +- Xapian::QueryParser::FLAG_LOVEHATE | +- Xapian::QueryParser::FLAG_BOOLEAN_ANY_CASE | +- Xapian::QueryParser::FLAG_WILDCARD | +- Xapian::QueryParser::FLAG_PURE_NOT); + + if (strcmp (query_string, "") == 0 || + strcmp (query_string, "*") == 0) +@@ -592,7 +580,7 @@ _notmuch_query_count_documents (notmuch_query_t *query, const char *type, unsign + final_query = mail_query; + } else { + string_query = notmuch->query_parser-> +- parse_query (query_string, flags); ++ parse_query (query_string, NOTMUCH_QUERY_PARSER_FLAGS); + final_query = Xapian::Query (Xapian::Query::OP_AND, + mail_query, string_query); + } +-- +2.8.1 +