From: Tomi Ollila Date: Tue, 21 May 2013 14:59:31 +0000 (+0300) Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX() X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=aa77fb30d321d8a0bb3f435c12ca3ff000e52a37;p=notmuch-archives.git Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX() --- diff --git a/ee/22b97ba933811d73b7808b4601c2b5d8223013 b/ee/22b97ba933811d73b7808b4601c2b5d8223013 new file mode 100644 index 000000000..f8fcb4bd9 --- /dev/null +++ b/ee/22b97ba933811d73b7808b4601c2b5d8223013 @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1ABB6431FC0 + for ; Tue, 21 May 2013 07:59:40 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id vQ7qcKnrnILK for ; + Tue, 21 May 2013 07:59:32 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id EB9CA431FB6 + for ; Tue, 21 May 2013 07:59:31 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 1537E1002C3; + Tue, 21 May 2013 17:59:31 +0300 (EEST) +From: Tomi Ollila +To: Ali Polatel +Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX() +In-Reply-To: <20130521144659.GA6002@hayalet> +References: <1369052664-17869-1-git-send-email-felipe.contreras@gmail.com> + <1369052664-17869-3-git-send-email-felipe.contreras@gmail.com> + <20130521144659.GA6002@hayalet> +User-Agent: Notmuch/0.15.2+99~g7e455bc (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 21 May 2013 14:59:40 -0000 + +On Tue, May 21 2013, Ali Polatel wrote: + +> 2013/05/21 Tomi Ollila : +>>On Mon, May 20 2013, Felipe Contreras wrote: +>> +>>> It has never existed in Ruby (maybe JRuby). Fortunately the symbols are +>>> loaded lazily, so nobody would notice unless they try +>>> 'query::count_messages'. +>>> +>>> Signed-off-by: Felipe Contreras +>> +>>This patch could be pushed on it's own, but someone (like Ali) could +>>comment on the change as searches on both UINT2FIX() & UINT2NUM() +>>provides (IMH) insatisfactory results... +> +> LGTM. +> +> My bad, there's no such thing as UINT2FIX(). +> Yet, what's wrong with UINT2NUM()? + +Nothing wrong -- although it seems obvious UINT2NUM() is the right thing +to do I was not qualified to say so... + +> +> The description looks like: +> "...take an unsigned int and convert it to a FIXNUM object if it will fit; +> otherwise, convert to a Bignum object..." + +... as I did not find this description when browsing the search results +(now this was in the first search result -- sometimes one just doesn't +get the right search terms in place)... + +> +> Besides ruby-1.8 has it and that's the oldest version I was willing to +> support. (If you have some free time, please confirm this because I may +> not be remembering correctly.) + +Cannot confirm for sure -- I found references to UINT2NUM() and ruby +1.8.6... + +.. anyway UINT2FIX() doesn't work and UINT2NUM() works with very high +probablility I'd say lets get this pushed. + +"Hey, it compiles! Ship It !" + +> +>>Tomi +> +> -alip + +Tomi