From: David Bremner <david@tethera.net>
Date: Tue, 29 Sep 2015 11:27:29 +0000 (+2100)
Subject: Re: [PATCH] cli: use designated initializer to initialize add_files_state
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a9ae8911a1721dbde1e7e15cbe1b05c4789d75e4;p=notmuch-archives.git

Re: [PATCH] cli: use designated initializer to initialize add_files_state
---

diff --git a/64/6cff2c64bf968a56c1988f1daaa27ec91b60cc b/64/6cff2c64bf968a56c1988f1daaa27ec91b60cc
new file mode 100644
index 000000000..f75e077b8
--- /dev/null
+++ b/64/6cff2c64bf968a56c1988f1daaa27ec91b60cc
@@ -0,0 +1,60 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 439D96DE0274
+ for <notmuch@notmuchmail.org>; Tue, 29 Sep 2015 04:29:47 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.106
+X-Spam-Level: 
+X-Spam-Status: No, score=0.106 tagged_above=-999 required=5 tests=[AWL=0.106]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id mit3odCfoy7Q for <notmuch@notmuchmail.org>;
+ Tue, 29 Sep 2015 04:29:45 -0700 (PDT)
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
+ by arlo.cworth.org (Postfix) with ESMTPS id 82BD66DE025E
+ for <notmuch@notmuchmail.org>; Tue, 29 Sep 2015 04:29:45 -0700 (PDT)
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
+ (envelope-from <david@tethera.net>)
+ id 1Zgt4g-00008n-6r; Tue, 29 Sep 2015 11:27:58 +0000
+Received: (nullmailer pid 754 invoked by uid 1000); Tue, 29 Sep 2015 11:27:29
+ -0000
+From: David Bremner <david@tethera.net>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] cli: use designated initializer to initialize
+ add_files_state
+In-Reply-To: <1443206855-21701-1-git-send-email-jani@nikula.org>
+References: <1443206855-21701-1-git-send-email-jani@nikula.org>
+User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Tue, 29 Sep 2015 08:27:29 -0300
+Message-ID: <87si5xqxcu.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 29 Sep 2015 11:29:47 -0000
+
+Jani Nikula <jani@nikula.org> writes:
+
+> The side effect is that all of add_files_state will be initialized to
+> zero, removing any lingering doubt that some of it might not be
+> initialized. It's not a small struct, and the initialization is
+> scattered around a bit, so this makes the code more readable.
+
+pushed
+
+d