From: Jinwoo Lee Date: Sun, 14 Jun 2015 15:16:03 +0000 (+1700) Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a963f894d192686b58984d9f917fdb3fe46a21b6;p=notmuch-archives.git Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable --- diff --git a/3e/c5bb25005c9292feaabc8b07c6fc9ad6ef437c b/3e/c5bb25005c9292feaabc8b07c6fc9ad6ef437c new file mode 100644 index 000000000..3057a7484 --- /dev/null +++ b/3e/c5bb25005c9292feaabc8b07c6fc9ad6ef437c @@ -0,0 +1,112 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id BEB1B6DE1639 + for ; Sun, 14 Jun 2015 08:16:17 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.562 +X-Spam-Level: +X-Spam-Status: No, score=-0.562 tagged_above=-999 required=5 + tests=[AWL=-0.011, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, + DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, + SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id z4dmp2mEIrFb for ; + Sun, 14 Jun 2015 08:16:15 -0700 (PDT) +Received: from mail-pd0-f182.google.com (mail-pd0-f182.google.com + [209.85.192.182]) + by arlo.cworth.org (Postfix) with ESMTPS id 8696C6DE15E3 + for ; Sun, 14 Jun 2015 08:16:15 -0700 (PDT) +Received: by pdbki1 with SMTP id ki1so54941121pdb.1 + for ; Sun, 14 Jun 2015 08:16:15 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=j8MZd99Gd9ZyvMc3B6vIPpVZpMFTlF6hm6aeHviCgYQ=; + b=AZRb3x2xlyLMkIqaKHNdKbBffUr5G6Zz6QUMX19H1aC0AQkRB1jnuS5i1ghk8BTNPF + vrAHPNMGFKfNFgvTHCVeLrMoFgRR4/VLR7aBz71ZcO6YoR6940QV8V0d//L5oJRfN+/f + jF7nCVka+XDV9r1AIus/CADx/YFEAnyP+Ra5HD9Y1o+rVmJkGfy57NEjk+6Nz24FZNdQ + uCTdR90l8glNZluTFGmtdXVkFzn+JPqBMeVcz04aJGo2eth10Z2QhYKPlFfq8/m/eJP0 + EewGNUwyNZeWIjynKWtcGiRRBQfAC+Rt86MCTKLhD5+h68am8UXe2TXPSKz14yKsRB5v + 5jjg== +X-Received: by 10.68.223.34 with SMTP id qr2mr39746394pbc.140.1434294975093; + Sun, 14 Jun 2015 08:16:15 -0700 (PDT) +Received: from localhost ([2601:647:4b02:71ea:aceb:ce29:cbf6:ded6]) + by mx.google.com with ESMTPSA id gp1sm9441088pbd.64.2015.06.14.08.16.12 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sun, 14 Jun 2015 08:16:13 -0700 (PDT) +From: Jinwoo Lee +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable +In-Reply-To: <87r3peye4q.fsf@maritornes.cs.unb.ca> +References: <1433142542-2307-3-git-send-email-david@tethera.net> + <1434261524-14139-1-git-send-email-david@tethera.net> + + <87r3peye4q.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.20.1+21~g4e79903 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-apple-darwin14.3.0) +Date: Sun, 14 Jun 2015 08:16:03 -0700 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 14 Jun 2015 15:16:17 -0000 + +On Sat, Jun 13, 2015 at 11:53 PM, David Bremner wrote: +> Jinwoo Lee writes: +> +>> There are 2 problems. +>> +>> 1. The file, bindings/Makefile.local still has lib/libnotmuch.so as the +>> dependency of ruby-bindings. +> +> this is fixed in +> +> id:1434263191-14171-1-git-send-email-david@tethera.net +> +> an updated patch sent a few minutes ago. +> +>> +>>> cd bindings/ruby && \ +>>> EXTRA_LDFLAGS="" \ +>>> ruby extconf.rb --vendor +>>> checking for notmuch_database_create in libnotmuch.so... no +>>> *** extconf.rb failed *** +> +> This should also be fixed by the same patch, since that test is +> eliminated. +> +>> ld: warning: ignoring file ../../lib/libnotmuch.dylib, file was built for x86_64 which is not the architecture being linked (i386): ../../lib/libnotmuch.dylib +> +> On the other hand, this suggests there is still something broken with +> building the ruby extensions on mac. I think if noone has a better idea, +> and the updated versions of the two patches I sent to the list this +> morning don't help, I'll just add a "--without-ruby" option to the +> config script. In the long run, we probably want such an option anyway. + +When I apply those 2 patches from you, things seem to work. I still get +warnings like below, but they don't seem severe. I'm not sure if the +ruby binding actually works though. + +ld: warning: directory not found for option '-L/usr/local/lib' +ld: warning: directory not found for option '-L/usr/local/lib' +ld: warning: ignoring file ../../lib/libnotmuch.dylib, file was built for x86_64 which is not the architecture being linked (i386): ../../lib/libnotmuch.dylib + +Thanks, David, for the quick fix! + +-jinwoo