From: Martin Waitz <tali@admingilde.org>
Date: Tue, 3 Oct 2006 18:07:43 +0000 (+0200)
Subject: gitweb: warn if feature cannot be overridden.
X-Git-Tag: v1.4.4-rc1~83^2~2
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a9455919064ab316b7852d0006c1bd771b727f2e;p=git.git

gitweb: warn if feature cannot be overridden.

If the administrator configures pathinfo to be overrideable by the
local repository a warning is shown.

Signed-off-by: Martin Waitz <tali@admingilde.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 10e803a97..0ff6f7c1e 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -116,6 +116,10 @@ sub gitweb_check_feature {
 		$feature{$name}{'override'},
 		@{$feature{$name}{'default'}});
 	if (!$override) { return @defaults; }
+	if (!defined $sub) {
+		warn "feature $name is not overrideable";
+		return @defaults;
+	}
 	return $sub->(@defaults);
 }