From: Mark Walters Date: Thu, 23 Jan 2014 21:51:23 +0000 (+0000) Subject: Re: [PATCH 1/2] notmuch dump: default to batch-tag format. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a890946b54f9f928011caaaccad1452026dc0cfe;p=notmuch-archives.git Re: [PATCH 1/2] notmuch dump: default to batch-tag format. --- diff --git a/56/dbb978f07eae3702fd244bd66938550395cdae b/56/dbb978f07eae3702fd244bd66938550395cdae new file mode 100644 index 000000000..63c0d950b --- /dev/null +++ b/56/dbb978f07eae3702fd244bd66938550395cdae @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 11647431FAF + for ; Thu, 23 Jan 2014 13:53:59 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id qUkGPRBR3X2d for ; + Thu, 23 Jan 2014 13:53:52 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 5BC01431FB6 + for ; Thu, 23 Jan 2014 13:53:52 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1W6SDZ-0006Yp-35; Thu, 23 Jan 2014 21:53:47 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1W6SCf-0004gj-Gp; Thu, 23 Jan 2014 21:52:49 +0000 +From: Mark Walters +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] notmuch dump: default to batch-tag format. +In-Reply-To: <1390482167-10473-1-git-send-email-david@tethera.net> +References: + <1390482167-10473-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 23 Jan 2014 21:51:23 +0000 +Message-ID: <87y5269xk4.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: d89f5f375a1458f1b760d4e7d018e8dd (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 23 Jan 2014 21:53:59 -0000 + + +This series LGTM +1 + +Best wishes + +Mark + +On Thu, 23 Jan 2014, David Bremner wrote: +> Although we didn't formally deprecate the old format, the new one has +> been available for a year. +> --- +> NEWS | 10 ++++++++++ +> notmuch-dump.c | 2 +- +> 2 files changed, 11 insertions(+), 1 deletion(-) +> +> diff --git a/NEWS b/NEWS +> index 28788d8..65679eb 100644 +> --- a/NEWS +> +++ b/NEWS +> @@ -1,3 +1,13 @@ +> +Notmuch 0.18 (UNRELEASED) +> +========================= +> + +> +Command-Line Interface +> +---------------------- +> + +> +`notmuch dump` now defaults to `batch-tag` format. +> + +> + The old format is still available with `--format=sup`. +> + +> Notmuch 0.17 (2013-12-30) +> ========================= +> +> diff --git a/notmuch-dump.c b/notmuch-dump.c +> index f8edda7..158142f 100644 +> --- a/notmuch-dump.c +> +++ b/notmuch-dump.c +> @@ -40,7 +40,7 @@ notmuch_dump_command (notmuch_config_t *config, int argc, char *argv[]) +> char *output_file_name = NULL; +> int opt_index; +> +> - int output_format = DUMP_FORMAT_SUP; +> + int output_format = DUMP_FORMAT_BATCH_TAG; +> +> notmuch_opt_desc_t options[] = { +> { NOTMUCH_OPT_KEYWORD, &output_format, "format", 'f', +> -- +> 1.8.5.2 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch