From: Jameson Graef Rollins Date: Tue, 20 Aug 2013 15:17:54 +0000 (+1700) Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a869d4d772736fe276fa141aff23803ade522573;p=notmuch-archives.git Re: [PATCH] emacs: add buttons for all multipart/related parts --- diff --git a/1d/5141601295b117ea1fe2b7b5f239220a5e5426 b/1d/5141601295b117ea1fe2b7b5f239220a5e5426 new file mode 100644 index 000000000..57e64082a --- /dev/null +++ b/1d/5141601295b117ea1fe2b7b5f239220a5e5426 @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A814D431FC0 + for ; Tue, 20 Aug 2013 08:18:08 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id kZEaRMFaNJQ5 for ; + Tue, 20 Aug 2013 08:18:04 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 444B0431FB6 + for ; Tue, 20 Aug 2013 08:18:04 -0700 (PDT) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id AC1A732802C; + Tue, 20 Aug 2013 08:18:01 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (cpe-76-173-75-27.socal.res.rr.com + [76.173.75.27]) (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id DADAE2E50D38; + Tue, 20 Aug 2013 08:17:57 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 627D761730; Tue, 20 Aug 2013 08:17:57 -0700 (PDT) +From: Jameson Graef Rollins +To: Istvan Marko , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts +In-Reply-To: +References: +User-Agent: Notmuch/0.16+1~g9f861e2 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Tue, 20 Aug 2013 08:17:54 -0700 +Message-ID: <87fvu4fl25.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 20 Aug 2013 15:18:08 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Fri, Aug 16 2013, Istvan Marko wrote: +> When text/html parts include images as multipart/related and the +> text/plain alternative is used these images can be completely hidden +> with no easy way to access them or even find out that they are there. +> +> Make notmuch-show-insert-part-multipart/related add buttons for all +> parts, the first one visible the rest hidden. + +Hey, Istvan. Thanks so much for this patch. It seems to be addressing +the same issue I reported in id:87ob8u8l6k.fsf@servo.finestructure.net. + +However, the behavior of the part button that now appears seems to be a +bit strange. Clicking/hitting enter on the part attempts to save it +rather than open it. I wouldn't be surprised if has nothing to do with +the correctness of this patch, though. So is it possible that the +button is not inserted in the most ideal way, or is there some other +issue preventing it from behaving properly (could it have to do with the +part being "inline"?)? + +jamie. + + +> emacs/notmuch-show.el | 4 ++++ +> 1 file changed, 4 insertions(+) +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index 82b70ba..20844f0 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -621,6 +621,10 @@ message at DEPTH in the current thread." +>=20=20 +> ;; Render the primary part. +> (notmuch-show-insert-bodypart msg (car inner-parts) depth) +> + ;; Add hidden buttons for the rest +> + (mapc (lambda (inner-part) +> + (notmuch-show-insert-bodypart msg inner-part depth t)) +> + (cdr inner-parts)) +>=20=20 +> (when notmuch-show-indent-multipart +> (indent-rigidly start (point) 1))) +> --=20 +> 1.8.1.4 + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.14 (GNU/Linux) + +iQIcBAEBCAAGBQJSE4ijAAoJEO00zqvie6q86CYP/ioM/6FNf947Gni2n2EpSgCs +csO1rxQrEHuLvcTljUDBfwP0R8NC7y22mGCl1iBx6mVcXKjPTQa97WVqBPRSYsJR +FcIycTW0MSBp5rOX8ZvsJG4DxlF8I+NLctne35uwWawE0LQqYz2QHERdr59YB438 +qVNdZkcakEPUaK44Upk9FIEo7efEtIjSBkCFIDEMgiTVOz+dqW79SuDRx1oJjeit +0eyKDtLdqXvfUjvI0xD/zcdYU36W2BI175EjmuAnr1Ow50Q73AQFzjaF+z4DtOjr ++saXVPiRiuO45LgvW0JAVc11sY8t1+caFjx2zFnRy/8viGyWEvnLmucoTf/yWAvR +L1PnI4Gb9qykGl2SS+npfuTrZdVgicun8S/H8n0lt5HEI03Ku2GzfF38kXB4w3dj +CBsZrCKAKCErSfhGp/ZvT4O6qCaZ08BRzZmXebXTPI5PKPTwEDBL7M9doCPT/ZvV +XspKqS9bKXfERos28sWUWAJxgxo7SCEiYqZgX4mKFpUk5jkOTY5oIWDWs+2C1EZa +HOI5ZQxCm7RjLbfz//o4zA4ukCTerMFRREwFfi8eju34Hdv1tBB0Zyo8k7vpv3Eu +cTmdxmOcmgTWOvNrKUx6cfoLZmFx42z7pHVVHU62GxvLHUIvLEuVDV2MPjlLgRev +5TnpD03LLoaZx4pM3rUB +=MEVP +-----END PGP SIGNATURE----- +--=-=-=--