From: David Bremner Date: Sat, 13 Sep 2014 08:07:54 +0000 (+0200) Subject: Re: [PATCH] test: simplify T360-symbol-hiding, use nm instead of objdump X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a8494ac8450c7e0550cf0986c494c7814cfbf04b;p=notmuch-archives.git Re: [PATCH] test: simplify T360-symbol-hiding, use nm instead of objdump --- diff --git a/4f/5e0beea8907b0540184f44c93de4056afe39ab b/4f/5e0beea8907b0540184f44c93de4056afe39ab new file mode 100644 index 000000000..3baff7332 --- /dev/null +++ b/4f/5e0beea8907b0540184f44c93de4056afe39ab @@ -0,0 +1,66 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 40F05431FC0 + for ; Sat, 13 Sep 2014 01:08:09 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id CA5P0iXnzCN3 for ; + Sat, 13 Sep 2014 01:08:04 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id EAEAA431FC4 + for ; Sat, 13 Sep 2014 01:08:03 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1XSiND-0004Ak-QF; Sat, 13 Sep 2014 05:07:59 -0300 +Received: (nullmailer pid 19171 invoked by uid 1000); Sat, 13 Sep 2014 + 08:07:54 -0000 +From: David Bremner +To: notmuch@notmuchmail.org +Subject: Re: [PATCH] test: simplify T360-symbol-hiding, use nm instead of + objdump +In-Reply-To: <1410331271-1403-1-git-send-email-david@tethera.net> +References: <1410331271-1403-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.18.1+85~gcca05ac (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 13 Sep 2014 10:07:54 +0200 +Message-ID: <87vboseyed.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 13 Sep 2014 08:08:09 -0000 + +David Bremner writes: + +> After yet another variation in objdump output caused this test to fail +> (on a Debian port, no less), I decided whatever putative benefit we +> get from looking at the object files instead of the library isn't +> worth the maintenence headache. +> +> This version uses nm -P. nm -P should be portable, and fixed format. +> It purposely doesn't use the -D argument, since that is non-POSIX and +> nm on GNU/Linux seems do the right thing without it. + +pushed to master + +d