From: Björn Steinbrink <B.Steinbrink@gmx.de>
Date: Thu, 5 Jun 2008 23:31:55 +0000 (+0200)
Subject: name-rev: Fix segmentation fault when using --all
X-Git-Tag: v1.5.5.4~2
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a83123deecfdd5078c2e16166576fb17add194b2;p=git.git

name-rev: Fix segmentation fault when using --all

In commit da2478db "describe --always: fall back to showing an
abbreviated object name" we lost the check that skips empty entries in
the object hash table when iterating over it in cmd_name_rev. That may
cause a NULL pointer being handed to show_name(), leading to a
segmentation fault. So add that check back again.

Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin-name-rev.c b/builtin-name-rev.c
index 384da4db1..521f061c9 100644
--- a/builtin-name-rev.c
+++ b/builtin-name-rev.c
@@ -280,9 +280,13 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
 		int i, max;
 
 		max = get_max_object_index();
-		for (i = 0; i < max; i++)
-			show_name(get_indexed_object(i), NULL,
+		for (i = 0; i < max; i++) {
+			struct object *obj = get_indexed_object(i);
+			if (!obj)
+				continue;
+			show_name(obj, NULL,
 				  always, allow_undefined, data.name_only);
+		}
 	} else {
 		int i;
 		for (i = 0; i < revs.nr; i++)