From: Jani Nikula Date: Mon, 8 Apr 2013 08:40:23 +0000 (+0200) Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a708a3ad2154ed81f52c79792b05c4e932cc9738;p=notmuch-archives.git Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. --- diff --git a/95/062a75e8d6d7e2fe6dc5c5c01785b1792f4559 b/95/062a75e8d6d7e2fe6dc5c5c01785b1792f4559 new file mode 100644 index 000000000..9eab0fe53 --- /dev/null +++ b/95/062a75e8d6d7e2fe6dc5c5c01785b1792f4559 @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B59A4431FB6 + for ; Mon, 8 Apr 2013 01:40:35 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id GucFEtov6Cdf for ; + Mon, 8 Apr 2013 01:40:35 -0700 (PDT) +Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com + [209.85.212.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C8799431FAE + for ; Mon, 8 Apr 2013 01:40:34 -0700 (PDT) +Received: by mail-wi0-f178.google.com with SMTP id ez12so2288061wid.17 + for ; Mon, 08 Apr 2013 01:40:32 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=x-received:from:to:cc:subject:in-reply-to:references:user-agent + :date:message-id:mime-version:content-type:x-gm-message-state; + bh=VVDYehbPmMuUc1M6Dpv/WI+adgJalMq4B5O1OUTENWo=; + b=QrFAumFShRVx+Bvu9xTvB3vviUuXDn4Udc1xDmkP3k7ORLReZXSfV6wtUv3ZBK2bMB + NN/ev6De7VAkBsHGfXej7gmFWRnBsTQw/Uhzlv8YymgUfgObMfJkAIOYvqt0pJDxkN5K + pR3YLDLlUnkAz5cxI477jFjx59Xy8ta5jTZPL5X6HInr4tlXJcdSZgMHqRZEzG9ntHb+ + brKTaGHLMInH7OGh2RbLDJKB+KdMfwbTktsAU+wn/g2irtwNg3ZAgSE5Dvyo3fFUvXn7 + olP7a8SQX68PAuyho6WrOExYeLV8eMzmoqEHM58QFDWehpR/zjMG6zzBqz88psZ2Tq96 + lH8A== +X-Received: by 10.194.119.33 with SMTP id kr1mr29749639wjb.36.1365410432194; + Mon, 08 Apr 2013 01:40:32 -0700 (PDT) +Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3]) + by mx.google.com with ESMTPS id gl11sm18198446wic.8.2013.04.08.01.40.30 + (version=TLSv1.1 cipher=RC4-SHA bits=128/128); + Mon, 08 Apr 2013 01:40:31 -0700 (PDT) +From: Jani Nikula +To: Tomi Ollila , Karl Fogel , + David Bremner +Subject: Re: [PATCH] emacs: add missing paren to fix defun in + notmuch-address.el. +In-Reply-To: +References: <87wqsfik5l.fsf@floss.red-bean.com> + <87mwtah2hd.fsf@zancas.localnet> + <877gkeau42.fsf@floss.red-bean.com> + +User-Agent: Notmuch/0.15.2+34~ga90fdd9 (http://notmuchmail.org) Emacs/23.2.1 + (x86_64-pc-linux-gnu) +Date: Mon, 08 Apr 2013 10:40:23 +0200 +Message-ID: <8738v1jtzc.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQnuNdQbzus+9oWsi09t2OEvD9ZcIbt1xfVAAAnXdK9/JfkQB/wFx3/xAv++QHPORPsT3k9j +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 08 Apr 2013 08:40:35 -0000 + +On Mon, 08 Apr 2013, Tomi Ollila wrote: +> The most tolerable way is to send new patch series w/ these 2 patches +> that apply cleanly on top of current master (661dcf87aeb70) so that the +> things that David needs to do are just to run `git am` and `make test`. + +I'd say just squash the two together. We already have the old reverted +commit that doesn't build, let's not add another commit that breaks +bisect (= every commit must build, work, and pass tests). + +BR, +Jani.