From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sat, 1 Jun 2013 20:49:45 +0000 (+0300)
Subject: Re: [PATCH] contrib: pick: use the sexp parser
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a5f4a7dec6dba28d808de6919414e526e78b83b1;p=notmuch-archives.git

Re: [PATCH] contrib: pick: use the sexp parser
---

diff --git a/8a/9f9201e11cf700f2d7759a226fb5b13088227e b/8a/9f9201e11cf700f2d7759a226fb5b13088227e
new file mode 100644
index 000000000..78f64e998
--- /dev/null
+++ b/8a/9f9201e11cf700f2d7759a226fb5b13088227e
@@ -0,0 +1,93 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1C8B8429E59
+	for <notmuch@notmuchmail.org>; Sat,  1 Jun 2013 13:49:56 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id nMkggCiWdfsT for <notmuch@notmuchmail.org>;
+	Sat,  1 Jun 2013 13:49:48 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id B8A69431FDE
+	for <notmuch@notmuchmail.org>; Sat,  1 Jun 2013 13:49:48 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 5C8DE100086;
+	Sat,  1 Jun 2013 23:49:45 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] contrib: pick: use the sexp parser
+In-Reply-To: <1370113483-10081-1-git-send-email-markwalters1009@gmail.com>
+References: <1370113483-10081-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.15.2+115~g12cf6af (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sat, 01 Jun 2013 23:49:45 +0300
+Message-ID: <m2r4gllfo6.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 01 Jun 2013 20:49:56 -0000
+
+On Sat, Jun 01 2013, Mark Walters <markwalters1009@gmail.com> wrote:
+
+> This just converts notmuch-pick to use the sexp parser.
+> ---
+
+These trivial changes look good -- is sexp already supported in show ?
+
+Tomi
+
+>
+>  contrib/notmuch-pick/notmuch-pick.el |    5 ++---
+>  1 files changed, 2 insertions(+), 3 deletions(-)
+>
+> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
+> index 128fabf..33905d6 100644
+> --- a/contrib/notmuch-pick/notmuch-pick.el
+> +++ b/contrib/notmuch-pick/notmuch-pick.el
+> @@ -773,8 +773,7 @@ Complete list of currently available key bindings:
+>          (save-excursion
+>            (goto-char (point-max))
+>            (insert string))
+> -	(notmuch-json-parse-partial-list 'notmuch-pick-insert-forest-thread
+> -					 'notmuch-pick-show-error
+> +	(notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread
+>  					 results-buf)))))
+>  
+>  (defun notmuch-pick-worker (basic-query &optional query-context target buffer)
+> @@ -796,7 +795,7 @@ Complete list of currently available key bindings:
+>      (if notmuch-pick-asynchronous-parser
+>  	(let ((proc (start-process
+>  		     "notmuch-pick" buffer
+> -		     notmuch-command "show" "--body=false" "--format=json"
+> +		     notmuch-command "show" "--body=false" "--format=sexp"
+>  		     message-arg search-args))
+>  	      ;; Use a scratch buffer to accumulate partial output.
+>                ;; This buffer will be killed by the sentinel, which
+> -- 
+> 1.7.9.1
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch