From: David Bremner Date: Thu, 31 Mar 2016 01:34:18 +0000 (+2100) Subject: Re: [PATCH 1/2] CLI: add print_status_database X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a5937743c81f88c42c9a919080889e3e9423bf67;p=notmuch-archives.git Re: [PATCH 1/2] CLI: add print_status_database --- diff --git a/23/7d15748f35c550796eaf71155e47ad5259dffb b/23/7d15748f35c550796eaf71155e47ad5259dffb new file mode 100644 index 000000000..e5f97254e --- /dev/null +++ b/23/7d15748f35c550796eaf71155e47ad5259dffb @@ -0,0 +1,68 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id CF00C6DE0297 + for ; Wed, 30 Mar 2016 18:34:32 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.021 +X-Spam-Level: +X-Spam-Status: No, score=-0.021 tagged_above=-999 required=5 + tests=[AWL=-0.010, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id A9WE_J5PL0sf for ; + Wed, 30 Mar 2016 18:34:23 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 65F496DE0173 + for ; Wed, 30 Mar 2016 18:34:23 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1alRVe-00014W-Ga; Wed, 30 Mar 2016 21:34:54 -0400 +Received: (nullmailer pid 11455 invoked by uid 1000); + Thu, 31 Mar 2016 01:34:18 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] CLI: add print_status_database +In-Reply-To: +References: <1459303814-31988-1-git-send-email-david@tethera.net> + <1459303814-31988-2-git-send-email-david@tethera.net> + +User-Agent: Notmuch/0.21+74~g6c60fb1 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Wed, 30 Mar 2016 22:34:18 -0300 +Message-ID: <874mbnjuqt.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 31 Mar 2016 01:34:33 -0000 + +Tomi Ollila writes: + +> +> LGTM (whole series). + +Pushed the series +> +> I was going to complain about the naming of 'print_status_database()' +> but David already got through (in 39c54df2) print_status_query() so +> that ship sailed already (perhaps that it happened is good :). +> + +Hmm, well, it's not API, so if we want to rename them we can. +Of course, the longer we leave it, the more pain. + +d