From: David Edmondson Date: Mon, 8 Sep 2014 09:19:50 +0000 (+0100) Subject: Re: [Patch v2 0/2] emacs: show: mark messages read if seen in buffer X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a51df30dc31f9cfc14c495ef28583f49008886e0;p=notmuch-archives.git Re: [Patch v2 0/2] emacs: show: mark messages read if seen in buffer --- diff --git a/5c/dfe0d4169e05e13aa903cb988bc48c894cb8e9 b/5c/dfe0d4169e05e13aa903cb988bc48c894cb8e9 new file mode 100644 index 000000000..63e7efa1c --- /dev/null +++ b/5c/dfe0d4169e05e13aa903cb988bc48c894cb8e9 @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0B049431FBC + for ; Mon, 8 Sep 2014 02:20:00 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id S8rCV0ATB9nn for ; + Mon, 8 Sep 2014 02:19:56 -0700 (PDT) +Received: from mail-we0-f174.google.com (mail-we0-f174.google.com + [74.125.82.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D6C44431FB6 + for ; Mon, 8 Sep 2014 02:19:55 -0700 (PDT) +Received: by mail-we0-f174.google.com with SMTP id t60so775391wes.5 + for ; Mon, 08 Sep 2014 02:19:53 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:user-agent + :from:date:message-id:mime-version:content-type; + bh=uPYBXi2pGwqnKFJ+3m9H+Hm0BoASDIGoZpXTAJkKbYI=; + b=IwydY1AArVfvNSMU6JEKhKmW0f941lhaeH9l4Lm8Cn7XKZStkiy9kQShQopRxtZ3uT + P6zXR10RHWQfhZFA7tC1dU5PpXXslqEtRmv/jWhEtJBR9ln4Z5M1x7wuDBiYqm86SNx9 + 9ogDKAZuqzn+LK4M+A5nOn/OUO1TPcfoX452rZ9aTEvvvckx+O60eXmaYpRrjVusoqrh + n/3BPvsTuYELIlY+ndK7dBhdh4MOCm+Gl8/w5pBNYP8GgBrvxaX1ttz6/+tyDkBfG+wf + 4w25j4+RRDbJBEI8tVCQA9Pc6rvOS/SzV01bSmL10pn0Uz0JXBFAJu+dQrZ8ojGtgpew + tuRQ== +X-Gm-Message-State: + ALoCoQkqhf8zCzl/BGOwQmv3cwz7LgbKvk+l8AXqX/cNDY7SavS37+SAmOjplRqgR0oCYjhD0+i0 +X-Received: by 10.194.3.106 with SMTP id b10mr32575029wjb.3.1410167993428; + Mon, 08 Sep 2014 02:19:53 -0700 (PDT) +Received: from localhost ([2a01:348:1a2:1:c97f:acf4:c706:7534]) + by mx.google.com with ESMTPSA id + pc6sm10396649wjb.43.2014.09.08.02.19.52 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Mon, 08 Sep 2014 02:19:52 -0700 (PDT) +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [Patch v2 0/2] emacs: show: mark messages read if seen in buffer +In-Reply-To: <1410020531-24419-1-git-send-email-markwalters1009@gmail.com> +References: <1410020531-24419-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-apple-darwin) +From: David Edmondson +Date: Mon, 08 Sep 2014 10:19:50 +0100 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 08 Sep 2014 09:20:00 -0000 + +I like the general approach. + +On Sat, Sep 06 2014, Mark Walters wrote: +> There are two changes from v1. First patch 1 is new. Secondly I have +> modified the defcustom for the second patch. It is slightly fiddly as +> my function has a parameter the default function does not. The +> defcustom in the previous patch worked but it was unable to parse +> itself so when you revisited the defcustom it looked like you had +> specified the lisp manually rather than having selected one of the two +> options. + +Is this because you want to include the parameter at the same point in +the custom definition? It's not uncommon to have a separate variable for +(things like) the proportion. It would make the declaration much simpler. + +> I like this version of the mark read function; but it is quite a lot +> of code (all unused unless the user selects this option so it is low +> risk). If people would prefer not to include it then I can just post +> the relevant code to the wiki and people can add it to their .emacs +> file if they want this function. + +If it's not the default, then I would be in favour of including it.