From: Jani Nikula Date: Sat, 17 Oct 2015 08:04:39 +0000 (+0300) Subject: Re: [PATCH 0/2] Saved searches in tree view X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a496cffcd82cf03091a70b58670848554bc3218e;p=notmuch-archives.git Re: [PATCH 0/2] Saved searches in tree view --- diff --git a/ee/86e923614b680240890c0d8c691ddb3a412746 b/ee/86e923614b680240890c0d8c691ddb3a412746 new file mode 100644 index 000000000..106c6f078 --- /dev/null +++ b/ee/86e923614b680240890c0d8c691ddb3a412746 @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id DA4086DE0B27 + for ; Sat, 17 Oct 2015 01:05:12 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.523 +X-Spam-Level: +X-Spam-Status: No, score=-0.523 tagged_above=-999 required=5 tests=[AWL=0.197, + RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id G04Xv7fl_CDt for ; + Sat, 17 Oct 2015 01:05:10 -0700 (PDT) +Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com + [209.85.212.179]) + by arlo.cworth.org (Postfix) with ESMTPS id 2AD116DE0AC2 + for ; Sat, 17 Oct 2015 01:05:09 -0700 (PDT) +Received: by wicgb1 with SMTP id gb1so34585642wic.1 + for ; Sat, 17 Oct 2015 01:05:08 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=lAJrZ9Ej8VQc5BjOuz+2G2FD5saJotdWVR83O8FFWRc=; + b=bL4ChlQPxYFNEylqIdI5vrDDU185D7ukYpchevPa8CBiMqOVzrzMkPEscIygfz5oRv + g2Nla+pS8Hm/3TPJV4kgcO+UQLmmkKYcjslTEUSAI99RU47eVhdPa+RtccVsvcTX+/b3 + eJPVtW7Pdo0qL6+dzSe0JIIQy22ZFmDayybgIhRljD+UhvFvbxn6cYJFF3Mw5RC28hu/ + SC3s9/DTmsc6ghM4OvIXN7O0dgAhUrHbAy6JZI+WyT0Wl7orMRjH+WHRTE9cz1vaTdXD + ZmKbkU0y0JhRm9fTobFuZRqrksidAxLHpYra3gdvGKepNT7dy0j9XMjyN0yQPNkwqFlp + bgkw== +X-Gm-Message-State: + ALoCoQmiSAyL2H3dNGkhbq13c9Z1hYp5hGH88PrjSjYp/jinkJ90yZSH0AwN47Tjo7dwqWjgmk+2 +X-Received: by 10.180.184.201 with SMTP id ew9mr9777360wic.53.1445069107838; + Sat, 17 Oct 2015 01:05:07 -0700 (PDT) +Received: from localhost (mobile-access-bcee43-111.dhcp.inet.fi. + [188.238.67.111]) + by smtp.gmail.com with ESMTPSA id bf8sm26939398wjc.22.2015.10.17.01.05.06 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 17 Oct 2015 01:05:07 -0700 (PDT) +From: Jani Nikula +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/2] Saved searches in tree view +In-Reply-To: <1444811903-16741-1-git-send-email-markwalters1009@gmail.com> +References: <1444811903-16741-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.21~rc0+2~gb7a0eab (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 17 Oct 2015 11:04:39 +0300 +Message-ID: <87bnbxnco8.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 17 Oct 2015 08:05:13 -0000 + +On Wed, 14 Oct 2015, Mark Walters wrote: +> The first patch allows the user to customize saved searches to show +> in tree view rather than search view (the choice also applies when the +> saved-search is called from notmuch-jump rather than notmuch-hello). +> +> The second patch lets a user switch back from tree mode to search mode +> with "S". This is analogous to using Z to switch from search mode or +> show mode to tree mode. This patch is independent of the first patch, +> but is more likely to be useful after the first patch. + +I like these, seems to work nicely. Can't offer much in terms of review +though. + +BR, +Jani. + +> +> One small caveat: if you customize the saved-searches then existing +> notmuch-hello buffers are not updated -- you need to refresh the +> buffer before the change will register. (The same is true for changing +> the sort order etc) +> +> Best wishes +> +> Mark +> +> +> Mark Walters (2): +> emacs: allow saved searches to select tree-view +> emacs: tree: bind S to run the current query in search mode +> +> emacs/notmuch-hello.el | 21 ++++++++++++++++----- +> emacs/notmuch-jump.el | 4 +++- +> emacs/notmuch-tree.el | 8 ++++++++ +> 3 files changed, 27 insertions(+), 6 deletions(-) +> +> -- +> 2.1.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch