From: David Bremner Date: Wed, 24 Sep 2014 19:25:20 +0000 (+0200) Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a47cf9999de392a4cd70a0d826514fdd44fdf404;p=notmuch-archives.git Re: [PATCH] lib: Simplify close and codify aborting atomic section --- diff --git a/62/3893aa0521bf6116b45366c43ef344869bf778 b/62/3893aa0521bf6116b45366c43ef344869bf778 new file mode 100644 index 000000000..5a0a13988 --- /dev/null +++ b/62/3893aa0521bf6116b45366c43ef344869bf778 @@ -0,0 +1,72 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 182F6431FB6 + for ; Wed, 24 Sep 2014 12:25:34 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3snuF4Ickw80 for ; + Wed, 24 Sep 2014 12:25:30 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A8087431FAF + for ; Wed, 24 Sep 2014 12:25:30 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1XWsBq-0001md-O9; Wed, 24 Sep 2014 16:25:26 -0300 +Received: (nullmailer pid 22782 invoked by uid 1000); Wed, 24 Sep 2014 + 19:25:20 -0000 +From: David Bremner +To: "W. Trevor King" +Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section +In-Reply-To: <20140924181844.GB20130@odin.tremily.us> +References: <1411400615-20934-1-git-send-email-amdragon@mit.edu> + <20140922165954.GI20827@odin.tremily.us> + <20140922185050.GB7970@csail.mit.edu> + <20140922190022.GO20827@odin.tremily.us> + <87iokc28mg.fsf@maritornes.cs.unb.ca> + <20140924181844.GB20130@odin.tremily.us> +User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 24 Sep 2014 21:25:20 +0200 +Message-ID: <87d2ak253z.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 24 Sep 2014 19:25:34 -0000 + +"W. Trevor King" writes: + +> +> Sorry, I didn't phrase that very well. The notmuch docs (as of this +> patch) explain that we don't commit if we're in an atomic block. The +> Xapian docs also say that, *and* they say that if we're not in atomic +> block the close *does* try to commit. I think that's worth mentioning +> in our close docs. + +OK, I see what you mean. I think the fact that you have to close the +notmuch database (when not using begin/end atomic) to get a commit is +surprising for many people, so it would be nice to make that clearer +somehow. + +d