From: Jani Nikula Date: Tue, 4 Mar 2014 19:37:35 +0000 (+0200) Subject: Re: [PATCH v2 00/13] literal folder: prefix, new path: prefix X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a46511bff5f0169e78126afc3a5097fbeb7ed603;p=notmuch-archives.git Re: [PATCH v2 00/13] literal folder: prefix, new path: prefix --- diff --git a/b4/04401229a56ef4f3bf789679165639f8f41612 b/b4/04401229a56ef4f3bf789679165639f8f41612 new file mode 100644 index 000000000..dce0360ea --- /dev/null +++ b/b4/04401229a56ef4f3bf789679165639f8f41612 @@ -0,0 +1,143 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 36D7D431FBF + for ; Tue, 4 Mar 2014 11:37:44 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Rw6ZEeH76ckI for ; + Tue, 4 Mar 2014 11:37:40 -0800 (PST) +Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com + [74.125.83.54]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + BA2BF431FBD for ; Tue, 4 Mar 2014 11:37:39 -0800 + (PST) +Received: by mail-ee0-f54.google.com with SMTP id d49so1698533eek.13 + for ; Tue, 04 Mar 2014 11:37:38 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=o0+Yv1XiVA2mOZOpDPK6MSpxNo95NTOKqdTCp1SPUZo=; + b=Po0jPcl8NQsyb3HKr0NU/bXm/C4Xre8OBbOVPKcOfZsrwh0STuBhDvzhLt/plYKg6e + UXLQ4RcTkwHn511UaCYuhIKyTZJtuZB5prB9B7lVcnuSDzZHnklrwfRR5V5gqOsSLpNO + 6DuV7cNv5AhIjeQ6/9Bq6o3efLuYeFgYv6x3ncTYEDoTlC1Eiwc6hKseb22v0K6peLE/ + EkyNkAWyz9hgU3VKLONtmG7+6/Pxjt57nWsCiGW1Bz9ZX/EVB4ZP83KccaQC8ZKmp28H + 0tvclLAQhQpDgBOJbZEkqfYrekfC4wLDrJ6VLIr8IulnA92lUuTxytO0QghdcSUhSRD4 + YiYA== +X-Gm-Message-State: + ALoCoQlGtACDEBUf0+UgsnM28rxX5wShYdNzUbgXRVJy46uELBuv6gMpJanIjbdZQSw/d+lu5IgS +X-Received: by 10.14.175.129 with SMTP id z1mr1116153eel.97.1393961858437; + Tue, 04 Mar 2014 11:37:38 -0800 (PST) +Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. + [88.195.111.91]) by mx.google.com with ESMTPSA id + o43sm66900569eef.12.2014.03.04.11.37.36 for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Tue, 04 Mar 2014 11:37:37 -0800 (PST) +From: Jani Nikula +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 00/13] literal folder: prefix, new path: prefix +In-Reply-To: <87mwh8mn58.fsf@zancas.localnet> +References: + <87mwh8mn58.fsf@zancas.localnet> +User-Agent: Notmuch/0.17+101~g2c5a6ae9e6e9 (http://notmuchmail.org) + Emacs/24.3.1 (x86_64-pc-linux-gnu) +Date: Tue, 04 Mar 2014 21:37:35 +0200 +Message-ID: <87siqxiwlc.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Mar 2014 19:37:44 -0000 + +On Sun, 02 Mar 2014, David Bremner wrote: +> Jani Nikula writes: +>> +>> I've dropped most of the content in patches 7 and 10 due to their +>> size. The patches (and the whole series) are available in the +>> boolean-folder-and-path-v2 branch at +>> git://gitorious.org/jani/notmuch.git. Web interface at +>> https://gitorious.org/jani/notmuch/commits/0b3dd2d1cc6c413ea07ea326883ac448499c0e79. +>> +> +> Hi Jani; +> +> I put a some proposed changes at +> +> http://pivot.cs.unb.ca/git?p=notmuch.git;a=shortlog;h=refs/heads/boolean-folder-and-path-v2 +> +> After playing with it a bit, I decided to +> +> - leave the source for the corpuses in the main tree. As we +> discussed, we don't expect them to change much, and they are +> text files. +> +> - store the binary database blobs externally. We could make the +> same argument about infrequent changes here, except that even +> the tiniest change will in practice require a whole new copy be +> stored. +> +> - compute a checksum file +> - test: add machinery to fetch and publish test databases +> - test: commit database-v1.tar.xz checksum, ignore actual database +> +> - this is an independant bug fix that should probably be pushed anyway: +> +> - test: don't use $(dir) in recipes. +> +> - I also made some unrelated changes including switching to xz +> compression. I intentionally didn't squash my patches into yours +> so you see and decide +> +> - convert to XZ compression +> - convert test to XZ +> +> Originally I thought metadata in the database tarball is +> needed. It turns out not. I think it's harmless, but feel free +> to drop it. +> +> - add some metadata to the database tarball + +I'm fine with all of the above. + +> - I struggled to find a way that would allow people to manage the +> tarballs in a nice way while not requiring everyone to +> install/learn new tools. My conclusion is in +> +> - test: add support for git annex managing test databases +> +> We still need to think about what to do for people installing from +> tarballs. As it stands they will need to either have network access or +> skip the relevant tests. Probably at least one followup patch is needed +> here. The alternative would be to include the database tarballs in the +> source; this will pretty quickly double the size of the source tarball. + +I think we should use the prereq mechanism in the tests to check if a +required test database is in place, skipping the test if not. This +should be fairly straightforward to do, and does not care *how* the test +database is to be fetched. (I'm undecided whether the test should verify +the checksum, or the part that fetches the database. Minor detail.) + +I know git annex in principle, but don't have any practical experience +with it. I don't really have any ideas for that. + + +BR, +Jani.