From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Fri, 12 Feb 2016 17:14:36 +0000 (+0200)
Subject: Re: [PATCH v3] emacs: Report a lack of matches when calling `notmuch-show'.
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a3ade2a77a2244a52352a8d0428f268b9b688b71;p=notmuch-archives.git

Re: [PATCH v3] emacs: Report a lack of matches when calling `notmuch-show'.
---

diff --git a/34/3cd7c90b3424cbbb5dc717ee9f35edc5a34fbc b/34/3cd7c90b3424cbbb5dc717ee9f35edc5a34fbc
new file mode 100644
index 000000000..3be5e9553
--- /dev/null
+++ b/34/3cd7c90b3424cbbb5dc717ee9f35edc5a34fbc
@@ -0,0 +1,74 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 88FAA6DE0C51
+ for <notmuch@notmuchmail.org>; Fri, 12 Feb 2016 09:14:26 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.641
+X-Spam-Level: 
+X-Spam-Status: No, score=0.641 tagged_above=-999 required=5 tests=[AWL=-0.011,
+  SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id PbgdXcNGC5dL for <notmuch@notmuchmail.org>;
+ Fri, 12 Feb 2016 09:14:24 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 30F6C6DE0A9A
+ for <notmuch@notmuchmail.org>; Fri, 12 Feb 2016 09:14:23 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id A725110007F;
+ Fri, 12 Feb 2016 19:14:36 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v3] emacs: Report a lack of matches when calling
+ `notmuch-show'.
+In-Reply-To: <1455179607-16870-2-git-send-email-dme@dme.org>
+References: <1455179607-16870-1-git-send-email-dme@dme.org>
+ <1455179607-16870-2-git-send-email-dme@dme.org>
+User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Fri, 12 Feb 2016 19:14:36 +0200
+Message-ID: <m2io1tx343.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 12 Feb 2016 17:14:26 -0000
+
+On Thu, Feb 11 2016, David Edmondson <dme@dme.org> wrote:
+
+> If the basic query passed to `notmuch-show' generates no results, ring
+> the bell and inform the user that no messages matched the query rather
+> than displaying an empty buffer and showing an obscure error.
+
+Looks good (the parts I understood) and works fine (testing with
+devel/try-emacs-mua). 
+
+FYI: when testing with (eval-last-sexp) interactively (c-x c-e)
+message does not appear in minibuffer -- since the following 'nil'
+will take its place -- the msg is in *Messages* buffer
+
+Tomi
+
+>
+> Similarly when refreshing a `notmuch-show' buffer and no messages match.
+> ---
+>  emacs/notmuch-show.el | 144 +++++++++++++++++++++++++++++---------------------
+>  emacs/notmuch.el      |   6 ++-
+>  2 files changed, 89 insertions(+), 61 deletions(-)
+>