From: Austin Clements Date: Sat, 24 Jan 2015 17:29:48 +0000 (+1900) Subject: Re: [PATCH 00/11] Improve charset and cid: handling X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a3a4f3b3b1504428a971fda6400bf8a80c566776;p=notmuch-archives.git Re: [PATCH 00/11] Improve charset and cid: handling --- diff --git a/1e/96940313d38c2cdb759e5cd2e501d14047bf15 b/1e/96940313d38c2cdb759e5cd2e501d14047bf15 new file mode 100644 index 000000000..a3146e08f --- /dev/null +++ b/1e/96940313d38c2cdb759e5cd2e501d14047bf15 @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6D8B4431FCB + for ; Sat, 24 Jan 2015 09:29:52 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.138 +X-Spam-Level: +X-Spam-Status: No, score=0.138 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_MED=-2.3] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fAZfQNgz2nyh for ; + Sat, 24 Jan 2015 09:29:49 -0800 (PST) +Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149]) + by olra.theworths.org (Postfix) with ESMTP id 34AA0431FAE + for ; Sat, 24 Jan 2015 09:29:49 -0800 (PST) +Received: from [104.131.20.129] (helo=awakeningjr) + by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) + (Exim 4.72) (envelope-from ) + id 1YF4Wq-0004cb-Rq; Sat, 24 Jan 2015 12:29:48 -0500 +Received: from amthrax by awakeningjr with local (Exim 4.84) + (envelope-from ) + id 1YF4Wq-0003bf-Ij; Sat, 24 Jan 2015 12:29:48 -0500 +From: Austin Clements +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 00/11] Improve charset and cid: handling +In-Reply-To: <87tx9gl5yn.fsf@qmul.ac.uk> +References: <1398105468-14317-1-git-send-email-amdragon@mit.edu> + <87tx9gl5yn.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 24 Jan 2015 12:29:48 -0500 +Message-ID: <87y4ost7cj.fsf@csail.mit.edu> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 24 Jan 2015 17:29:52 -0000 + +I added declare-functions for both of these, which should take care of +the Emacs 23 warnings and be more robust on Emacs 24. We can't reach +the function that calls these unless shr is actually available, but the +byte compiler doesn't know that. + +On Sat, 26 Apr 2014, Mark Walters wrote: +> Aside from the minor comments I mentioned in previous emails and one +> more comment below this looks good. +> +> The extra comment is that on emacs23 I get the following when compiling: +> +> In end of data: +> notmuch-show.el:2188:1:Warning: the following functions are not known to be +> defined: libxml-parse-html-region, shr-insert-document +> +> Finally, I have not really tested it as I mainly use emacs23 +> +> Best wishes +> +> Mark +> +> +> +> +> On Mon, 21 Apr 2014, Austin Clements wrote: +>> I set out to quickly add support for cid: links in the shr renderer +>> and wound up making our charset handling more robust and rewriting our +>> content-ID handling. The test introduced in patch 2 passes in all but +>> one really obscure case, but only because of many unwritten and +>> potentially fragile assumptions that Emacs and the CLI make about each +>> other. +>> +>> The first three patches could reasonably go in to 0.18. The rest of +>> this series is certainly post-0.18, but I didn't want to lose track of +>> it. +>> +>> This series comes in three stages. Each depends on the earlier ones, +>> but each prefix makes sense on its own and could be pushed without the +>> later stages. +>> +>> Patch 1 is a simple clean up patch. +>> +>> Patches 2 through 7 robust-ify our charset handling in Emacs, mostly +>> by splitting the broken `notmuch-get-bodypart-content' API into +>> `notmuch-get-bodypart-binary' and `notmuch-get-bodypart-text' so a +>> caller can explicitly convey their requirements. +>> +>> The remaining patches improve our content-ID handling and add support +>> for cid: links for shr. +>> +>> _______________________________________________ +>> notmuch mailing list +>> notmuch@notmuchmail.org +>> http://notmuchmail.org/mailman/listinfo/notmuch