From: David Bremner <david@tethera.net>
Date: Fri, 7 Nov 2014 08:53:09 +0000 (+0100)
Subject: Re: [PATCH] cli: notmuch address option defaults update
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a3591ad2c68fc31222dc2a0561d205ad14fedd49;p=notmuch-archives.git

Re: [PATCH] cli: notmuch address option defaults update
---

diff --git a/90/dd418fb002cbc662ba2c787c5aaf5c091796a1 b/90/dd418fb002cbc662ba2c787c5aaf5c091796a1
new file mode 100644
index 000000000..7567ddf86
--- /dev/null
+++ b/90/dd418fb002cbc662ba2c787c5aaf5c091796a1
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1827F431FB6
+	for <notmuch@notmuchmail.org>; Fri,  7 Nov 2014 00:53:24 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 1X7D1QGsFF+c for <notmuch@notmuchmail.org>;
+	Fri,  7 Nov 2014 00:53:19 -0800 (PST)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 5F7E9431FAE
+	for <notmuch@notmuchmail.org>; Fri,  7 Nov 2014 00:53:19 -0800 (PST)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1XmfIA-0008LH-G3; Fri, 07 Nov 2014 04:53:14 -0400
+Received: (nullmailer pid 454 invoked by uid 1000); Fri, 07 Nov 2014 08:53:09
+	-0000
+From: David Bremner <david@tethera.net>
+To: Mark Walters <markwalters1009@gmail.com>, Tomi Ollila
+	<tomi.ollila@iki.fi>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] cli: notmuch address option defaults update
+In-Reply-To: <871tpf1krb.fsf@qmul.ac.uk>
+References: <1415297516-29203-1-git-send-email-tomi.ollila@iki.fi>
+	<871tpf1krb.fsf@qmul.ac.uk>
+User-Agent: Notmuch/0.19~rc1 (http://notmuchmail.org) Emacs/24.4.1
+	(x86_64-pc-linux-gnu)
+Date: Fri, 07 Nov 2014 09:53:09 +0100
+Message-ID: <87sihv1jey.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: tomi.ollila@iki.fi
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 07 Nov 2014 08:53:24 -0000
+
+Mark Walters <markwalters1009@gmail.com> writes:
+
+>> -	This option has no effect when used with --output=count.
+>> +        This option affects the seemingly random output order when
+>> +        used with --output=count.
+>
+> I know what this means but it confused me at first.  How about "When
+> used with --output=count this option changes the output from one
+> seemingly random order to a different seemingly random order"? 
+
+What about just saying "This option is not supported with
+--output=count".
+Then the fact that it doesn't crash or error out is a kind of bonus ;).
+Of course we could (later?) add a check for --sort && --output=count and
+report an errror.
+
+d