From: Ben Gamari Date: Tue, 5 Nov 2013 18:48:07 +0000 (+1900) Subject: Re: [PATCH v2 00/11] compactor changes v2 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a2896a61c4b953d3ac41f59354aa2eb86ef8f736;p=notmuch-archives.git Re: [PATCH v2 00/11] compactor changes v2 --- diff --git a/3c/7d107076526664e5d90ed1c771426fed5e9df2 b/3c/7d107076526664e5d90ed1c771426fed5e9df2 new file mode 100644 index 000000000..91c7fdb8b --- /dev/null +++ b/3c/7d107076526664e5d90ed1c771426fed5e9df2 @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8AFBD429E56 + for ; Tue, 5 Nov 2013 10:48:21 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id w2TXIq91DHjD for ; + Tue, 5 Nov 2013 10:48:15 -0800 (PST) +Received: from mail-qe0-f47.google.com (mail-qe0-f47.google.com + [209.85.128.47]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 67FBF431FDD + for ; Tue, 5 Nov 2013 10:48:15 -0800 (PST) +Received: by mail-qe0-f47.google.com with SMTP id b4so5205939qen.20 + for ; Tue, 05 Nov 2013 10:48:13 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=gzI0fvMK+pvsBYHMynDNDofOzSGAAsO+wGXvHNySuJ4=; + b=FfVocwyvBSwIWLKGm9R2s7qJ7QDLr3iClSglLEyI8S+06TVkPlanAdz0kq3CIARB4/ + Sqgz9yJbuYYObzC5ZiYXf5tH9C+bZesbmWbFZ14IP446CxECaezb6i/NVLrL5Ws2UQeB + u3PWqjX8SDoC2+mAxJW3NVoXBiFOdG0efcjK4nnvs2YWnnGTU+SNThOVwCSm9MhRN/5x + Thw6U60uteNrVdkcpVywTlHoCpEIYjTYCBSWYiu7aE1qn244KN3s1vy5eQZNdvi7/eJC + XGf6hvGxl4I7sX8v8woKHYEefiyi5WT7iJrCLHDq0qJ+L9XqXKoK9LoOpRgDPpOgURKo + f77g== +X-Received: by 10.49.117.41 with SMTP id kb9mr31098469qeb.79.1383677292754; + Tue, 05 Nov 2013 10:48:12 -0800 (PST) +Received: from localhost (physicsnat56.physics.umass.edu. [128.119.50.38]) + by mx.google.com with ESMTPSA id h2sm49272694qaf.10.2013.11.05.10.48.10 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Tue, 05 Nov 2013 10:48:12 -0800 (PST) +From: Ben Gamari +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 00/11] compactor changes v2 +In-Reply-To: +References: +User-Agent: Notmuch/0.16+107~g1ef2773 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Tue, 05 Nov 2013 13:48:07 -0500 +Message-ID: <87bo1yit20.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 05 Nov 2013 18:48:21 -0000 + +--=-=-= +Content-Type: text/plain + +Jani Nikula writes: + +> Hi all, this is v2 of [1], incorporating compact related patches from +> David, some changes from David's review, some new patches, man page +> update, test update. +> +Alas, more silly oversights on my part. Thanks for catching these! + +No objections from my side. Given that I've never seen a compact fail, I +think switching off backups by default seems fine. Personally I'll +likely always run with --verbose as even with an SSD compact can take +quite a while and there's nothing like watching a teapot to pass the +day. Regardless, I have no objection to the flag's existence. + +Cheers, + +- Ben + + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.14 (GNU/Linux) + +iQEcBAEBAgAGBQJSeT1oAAoJEErkyLZmeNiD1zkH/jrOVb7jOCyvJBBRIj+YD1kX +HTnLSQIjmuvPTSEtMb6Vmo6l/ajsV6stbkobCHb9FG0cB8OY8A0AuJ1mlpp61jkb +LCqh8LAEoBFnqA+FArxq/i3rOXYVjGcgRUTIYi+FhQ9UiFdZyGh0BaBmHpbVz526 +QdDUui+Cf7TgbiB/hpVjjS9you71/yUdlp+Xjz4iBtNRs7GA/QJ5Y3zCe3iAox5f +vt/LcFx71KJYU2FJYtDj4GlQpEC8ZOhVlXGSLnFhTb/UO4uRSNiaWvK1tpnYRwWp +rhoIdovvUClf4jtpLQ5SJy/1hj9LOpZCZu/PA5yVKEAYsQa6pddmTZEfhDQl6Ms= +=l2Sd +-----END PGP SIGNATURE----- +--=-=-=--