From: Austin Clements Date: Thu, 13 Feb 2014 07:10:27 +0000 (+1900) Subject: Re: [PATCH 1/1] emacs: always write emacs/.eldeps when the target is remade X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a25c4b7b4b3a176bff583f1f0d0c44cac9142f66;p=notmuch-archives.git Re: [PATCH 1/1] emacs: always write emacs/.eldeps when the target is remade --- diff --git a/9d/1b212aaca542c7d073ec0e0bf077d62277931f b/9d/1b212aaca542c7d073ec0e0bf077d62277931f new file mode 100644 index 000000000..5505e30dd --- /dev/null +++ b/9d/1b212aaca542c7d073ec0e0bf077d62277931f @@ -0,0 +1,108 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A49C1431FBD + for ; Wed, 12 Feb 2014 23:10:41 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id X5YlCV4b2hzz for ; + Wed, 12 Feb 2014 23:10:36 -0800 (PST) +Received: from dmz-mailsec-scanner-6.mit.edu (dmz-mailsec-scanner-6.mit.edu + [18.7.68.35]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B14A5431FAE + for ; Wed, 12 Feb 2014 23:10:36 -0800 (PST) +X-AuditID: 12074423-f79726d000000cc9-d2-52fc6feae991 +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + (using TLS with cipher AES256-SHA (256/256 bits)) + (Client did not present a certificate) + by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP + id CC.95.03273.AEF6CF25; Thu, 13 Feb 2014 02:10:34 -0500 (EST) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id s1D7AUn2021999; + Thu, 13 Feb 2014 02:10:32 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s1D7ARkJ022685 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Thu, 13 Feb 2014 02:10:30 -0500 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1WDqRH-0004VM-Ex; Thu, 13 Feb 2014 02:10:27 -0500 +Date: Thu, 13 Feb 2014 02:10:27 -0500 +From: Austin Clements +To: Tomi Ollila +Subject: Re: [PATCH 1/1] emacs: always write emacs/.eldeps when the target is + remade +Message-ID: <20140213071026.GX4375@mit.edu> +References: <1390645309-2326-1-git-send-email-tomi.ollila@iki.fi> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1390645309-2326-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hTV1n2V/yfI4N8aKYvrN2cyW7xZOY/V + gcnj8NeFLB7PVt1iDmCK4rJJSc3JLEst0rdL4MpYs/gwU0EnZ8WHWxfZGxi3s3cxcnJICJhI + 9B3aywJhi0lcuLeerYuRi0NIYDaTxKP+c0wQzkZGiXnP1zKBVAkJnGaSuL6bByKxhFHi4cKp + YAkWAVWJVa+7mEFsNgENiW37lzOC2CICKhIP2tazgtjMAtIS3343g9ULC4RJzFx0GqyeV0Bb + YuH9BSwQCxwlVp1dxQQRF5Q4OfMJC0SvlsSNfy+B4hxgc5b/4wAJcwo4SVzrPQFWIgq0asrJ + bWwTGIVmIemehaR7FkL3AkbmVYyyKblVurmJmTnFqcm6xcmJeXmpRbpmermZJXqpKaWbGEFh + ze6ivIPxz0GlQ4wCHIxKPLwXpv4OEmJNLCuuzD3EKMnBpCTKuzb3T5AQX1J+SmVGYnFGfFFp + TmrxIUYJDmYlEV4ZCaAcb0piZVVqUT5MSpqDRUmct9biV5CQQHpiSWp2ampBahFMVoaDQ0mC + 92UeUKNgUWp6akVaZk4JQpqJgxNkOA/QcK58kOHFBYm5xZnpEPlTjIpS4ryhIM0CIImM0jy4 + XljaecUoDvSKMO96kCoeYMqC634FNJgJaHBq1G+QwSWJCCmpBkaVhPKIzvquF6n13xondDxN + 2Xma5RFH7eOn7P6rexbvTD0k+E7D5GpPoFuhwvq/66cYPfl1jfHcyg3b9rGGnJ++om2GbJxq + wt+Tk54vmFa5R9bL/qzv9A35nLFfWiYbuZ+d+H6BpIRc3Z+tWj6rz3unPt68Y3bog4lnvlex + PFvEVxNk/HyT4m03JZbijERDLeai4kQAhC8y3xYDAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 13 Feb 2014 07:10:41 -0000 + +Quoth Tomi Ollila on Jan 25 at 12:21 pm: +> So that the target is newer than its prerequisites. +> --- +> emacs/Makefile.local | 3 +-- +> 1 file changed, 1 insertion(+), 2 deletions(-) +> +> diff --git a/emacs/Makefile.local b/emacs/Makefile.local +> index 42bfbd9..d5d402e 100644 +> --- a/emacs/Makefile.local +> +++ b/emacs/Makefile.local +> @@ -32,8 +32,7 @@ emacs_bytecode = $(emacs_sources:.el=.elc) +> ifeq ($(HAVE_EMACS),1) +> $(dir)/.eldeps: $(dir)/Makefile.local $(dir)/make-deps.el $(emacs_sources) +> $(call quiet,EMACS) --directory emacs -batch -l make-deps.el \ +> - -f batch-make-deps $(emacs_sources) > $@.tmp && \ +> - (cmp -s $@.tmp $@ || mv $@.tmp $@) +> + -f batch-make-deps $(emacs_sources) > $@.tmp && mv $@.tmp $@ +> -include $(dir)/.eldeps +> endif +> CLEAN+=$(dir)/.eldeps $(dir)/.eldeps.tmp + +Is this just so the rule doesn't get run again on the next make +invocation (unless, of course, a dependent changed)? + +Interestingly, if any of the dependents have changed, but in ways that +don't affect .eldeps, this change will make the build more expensive +because it will trigger a make restart after .eldeps is updated.