From: Karl Fogel Date: Tue, 8 Jul 2014 17:59:07 +0000 (+1900) Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a25518493a68d5674e6a155f22cce07af03dc195;p=notmuch-archives.git Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. --- diff --git a/c7/9f7314e75654311f7e2f8f39328bbc2cf05a56 b/c7/9f7314e75654311f7e2f8f39328bbc2cf05a56 new file mode 100644 index 000000000..2387daeae --- /dev/null +++ b/c7/9f7314e75654311f7e2f8f39328bbc2cf05a56 @@ -0,0 +1,87 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 36914431FB6 + for ; Tue, 8 Jul 2014 10:59:14 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.699 +X-Spam-Level: +X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 4XUDe5mr45ET for ; + Tue, 8 Jul 2014 10:59:10 -0700 (PDT) +Received: from mail-ig0-f172.google.com (mail-ig0-f172.google.com + [209.85.213.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 5A645431FAF + for ; Tue, 8 Jul 2014 10:59:10 -0700 (PDT) +Received: by mail-ig0-f172.google.com with SMTP id hn18so960774igb.17 + for ; Tue, 08 Jul 2014 10:59:09 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to + :message-id:user-agent:mime-version:content-type; + bh=Y/ccSXdNVE7gAAfPfSnfd+EzyKnocK9sil1hIkazQxs=; + b=s0vcuWcMC77P0ZrcWiWf2vae0QKMxB4TYEO481X66Ggrr9T+76Unqcpx5Bj34Sc2nC + PIDOTOwxd8+sjBOAPApcQneHrE8phqKVS469ORB7InNHyNuVGxymvl92vbJSkkJM/HXT + QerB7BbC7kXbGJ2OekWu/5fl43dBd3TSoSCvFUePwV4xYeAvK2Nn8x+4QrVMA5xpY71x + Ib1qtAFyWetaW2xHr1r1JFoy0rb2y6fUhDUXmtcQeP5gqHQxpLj8TKygADrFRhGG7zFH + qtbM7jXjhN+SlAL0Kwjcx9ry/TfGAjZCJxAzST4KNCn2ggFmmmVnHnb4qTeNnEyaEMFi + UKGQ== +X-Received: by 10.42.106.15 with SMTP id x15mr11458829ico.67.1404842348813; + Tue, 08 Jul 2014 10:59:08 -0700 (PDT) +Received: from ktab.red-bean.com + (74-92-190-113-Illinois.hfc.comcastbusiness.net. [74.92.190.113]) + by mx.google.com with ESMTPSA id y8sm7378341igg.5.2014.07.08.10.59.07 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Tue, 08 Jul 2014 10:59:08 -0700 (PDT) +Sender: Karl Fogel +From: Karl Fogel +To: Tomi Ollila +Subject: Re: [PATCH] emacs: add missing paren to fix defun + in notmuch-address.el. +References: <87wqsfik5l.fsf@floss.red-bean.com> + <87mwtah2hd.fsf@zancas.localnet> <877gkeau42.fsf@floss.red-bean.com> + <8738v1jtzc.fsf@nikula.org> + <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov> + <87vc7vgbym.fsf@zancas.localnet> + + <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> + <87oax6vt4u.fsf@ktab.red-bean.com> + <87bnt2dy0b.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> + +Date: Tue, 08 Jul 2014 12:59:07 -0500 +In-Reply-To: (Tomi Ollila's message of + "Tue, 08 Jul 2014 11:56:55 +0300") +Message-ID: <871ttvybo4.fsf@ktab.red-bean.com> +User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +Reply-To: Karl Fogel +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 08 Jul 2014 17:59:14 -0000 + +Tomi Ollila writes: +>but the bbdb-* looks a bit too generic (goes deep into bbdb "namespace" +>in a file not part of bbdb -package) + +Good point. Stuff in notmuch should have a consistent prefix. Prefixes +are Emacs' module system, after all :-). (It could be `notmuch-bbdb-*' +or whatever, of course.)