From: Austin Clements Date: Mon, 9 Dec 2013 00:33:15 +0000 (+1900) Subject: Re: [PATCH v3 part 3/3] test: implement and document NOTMUCH_TEST_QUIET variable... X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a1e3dc3416c8a5104eacc4421637333a0e727fc6;p=notmuch-archives.git Re: [PATCH v3 part 3/3] test: implement and document NOTMUCH_TEST_QUIET variable usage --- diff --git a/c6/7e034889ad2edee7350d2f06727da9e5f51daa b/c6/7e034889ad2edee7350d2f06727da9e5f51daa new file mode 100644 index 000000000..a008ab2fa --- /dev/null +++ b/c6/7e034889ad2edee7350d2f06727da9e5f51daa @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C5BD7431FD0 + for ; Sun, 8 Dec 2013 16:33:27 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 43WkgASZWzUB for ; + Sun, 8 Dec 2013 16:33:20 -0800 (PST) +Received: from dmz-mailsec-scanner-5.mit.edu (dmz-mailsec-scanner-5.mit.edu + [18.7.68.34]) + by olra.theworths.org (Postfix) with ESMTP id 33B52431FCB + for ; Sun, 8 Dec 2013 16:33:20 -0800 (PST) +X-AuditID: 12074422-b7f9d6d000000bc0-ad-52a50fcf1ab9 +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + (using TLS with cipher AES256-SHA (256/256 bits)) + (Client did not present a certificate) + by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP + id 27.6A.03008.FCF05A25; Sun, 8 Dec 2013 19:33:19 -0500 (EST) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id rB90XIfW018130; + Sun, 8 Dec 2013 19:33:19 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id rB90XG80008050 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Sun, 8 Dec 2013 19:33:17 -0500 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1Vpomh-0006QM-SI; Sun, 08 Dec 2013 19:33:15 -0500 +Date: Sun, 8 Dec 2013 19:33:15 -0500 +From: Austin Clements +To: Tomi Ollila +Subject: Re: [PATCH v3 part 3/3] test: implement and document + NOTMUCH_TEST_QUIET variable usage +Message-ID: <20131209003315.GA24583@mit.edu> +References: <1385399299-12936-1-git-send-email-tomi.ollila@iki.fi> + <1386247560-31903-1-git-send-email-tomi.ollila@iki.fi> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1386247560-31903-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hTV1j3PvzTI4Gi7lsX1mzOZLd6snMfq + wORx+OtCFo9nq24xBzBFcdmkpOZklqUW6dslcGUc3jeRpeA1e8W/bYsZGxhb2LoYOTkkBEwk + Nmxbzgxhi0lcuLceKM7FISQwm0li9sw5LBDOBkaJXbOeMkE4p5gkmiZfZYRwljBKrHqzgh2k + n0VARWL67AWsIDabgIbEtv3LGUFsEaD4g7b1YHFmAWmJb7+bmUBsYYFEiTlXz4Lt5hXQkejs + 2Qs2R0igWuJMzz+ouKDEyZlPWCB6tSRu/HsJ1MsBNmf5Pw6QMKeAs8TBl1fBxosCrZpychvb + BEahWUi6ZyHpnoXQvYCReRWjbEpulW5uYmZOcWqybnFyYl5eapGuqV5uZoleakrpJkZQYLO7 + KO1g/HlQ6RCjAAejEg/vCtalQUKsiWXFlbmHGCU5mJREeSdzA4X4kvJTKjMSizPii0pzUosP + MUpwMCuJ8CqdWBIkxJuSWFmVWpQPk5LmYFES573FYR8kJJCeWJKanZpakFoEk5Xh4FCS4H3H + BzRUsCg1PbUiLTOnBCHNxMEJMpwHaHgUSA1vcUFibnFmOkT+FKOilDgvJzB1CAmAJDJK8+B6 + YYnnFaM40CvCvJdB2nmASQuu+xXQYCagwZOuLgIZXJKIkJJqYOSXneF45+c35zVac/ek3rKf + mJNfJaUh/LZX5OVM59iHe2tmT94W3H7x+3cDgbafnnksSsrdmWyd1Rm35Re9maDm/O3o2plr + mBc+WX9jr6Xct9qLWv5Rpy5yaKz9Knswr+nXkpfl4iIFxtldfZxH1SJf64gENBsu0b7YqX1h + e+MJi022/pMDHymxFGckGmoxFxUnAgBv37V+FwMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 09 Dec 2013 00:33:28 -0000 + +v3 LGTM. + +Quoth Tomi Ollila on Dec 05 at 2:46 pm: +> When NOTMUCH_TEST_QUIET environment variable is set to non-null value +> messages when new test script starts and when test PASSes are disabled. +> This eases picking the cases when tests FAIL (as those are still printed). +> --- +> +> Diffdiff of part 3 to previous. +> +> | diff --git a/test/test-lib.sh b/test/test-lib.sh +> | index 9d4a807..d8e0d91 100644 +> | --- a/test/test-lib.sh +> | +++ b/test/test-lib.sh +> | @@ -733,9 +733,7 @@ test_failure_ () { +> | return +> | fi +> | test_failure=$(($test_failure + 1)) +> | - if test -n "$NOTMUCH_TEST_QUIET"; then +> | - print_test_description +> | - fi +> | + print_test_description +> | test_failure_message_ "FAIL" "$test_subtest_name" "$@" +> | test "$immediate" = "" || { GIT_EXIT_OK=t; exit 1; } +> | return 1 +> +> +> test/README | 8 ++++++++ +> test/basic | 4 ++-- +> test/test-lib.sh | 9 ++++++++- +> 3 files changed, 18 insertions(+), 3 deletions(-)