From: Mark Walters Date: Mon, 26 Aug 2013 19:57:21 +0000 (+0100) Subject: [PATCH 0/2] contrib: pick: remove sync parser X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a1d49c3ef64130fbb21d77b59117e3c53b6fd2ee;p=notmuch-archives.git [PATCH 0/2] contrib: pick: remove sync parser --- diff --git a/70/7549d2525aa1798713950ed27ac83efbcdbfb2 b/70/7549d2525aa1798713950ed27ac83efbcdbfb2 new file mode 100644 index 000000000..c25e87184 --- /dev/null +++ b/70/7549d2525aa1798713950ed27ac83efbcdbfb2 @@ -0,0 +1,87 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 38EC2431FD8 + for ; Mon, 26 Aug 2013 12:57:35 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.201 +X-Spam-Level: +X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id YLW0jf14ZJxz for ; + Mon, 26 Aug 2013 12:57:29 -0700 (PDT) +Received: from mail-we0-f170.google.com (mail-we0-f170.google.com + [74.125.82.170]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 86C53431FAF + for ; Mon, 26 Aug 2013 12:57:29 -0700 (PDT) +Received: by mail-we0-f170.google.com with SMTP id w62so3170441wes.15 + for ; Mon, 26 Aug 2013 12:57:28 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id; + bh=DPeWlIn2HrRnaSzG4ZYdbZ5fPpYoM58sykxuQ5nug8I=; + b=0WfR355uIWTCmIOJfMxnW2o2vgeGiCTB+RFDZ56W57X8XX8U/jJyMSmbiMYeuIzY2O + ty787HlmlzliEbub04w/tjDh7VbvV8MzzShvvnhOJXmulbwKLrJG1p8fwpdPtpKjE0Gp + GJLc4QBesesWj1mFtRgM+JZAe3g+B3TPl4165vTBDP6E4E0Eb3imYKLPasGLCe4HPhzh + yFLZg0T/dMlFBSoWI5UDSJX0FaPejcMCBW09KIe/3sCn0TEHOWM2QKNCJihSWrLG0rUn + FHxmxjaE3/R6BTUTbB97eBgY9qwI3cWSEEdIsXMbnNAq0vXrgjnqdYcwVspVY6vWQ/AF + T0HA== +X-Received: by 10.194.250.6 with SMTP id yy6mr11329648wjc.13.1377547048308; + Mon, 26 Aug 2013 12:57:28 -0700 (PDT) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id r6sm21005311wiw.0.1969.12.31.16.00.00 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Mon, 26 Aug 2013 12:57:27 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 0/2] contrib: pick: remove sync parser +Date: Mon, 26 Aug 2013 20:57:21 +0100 +Message-Id: <1377547043-17584-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 26 Aug 2013 19:57:35 -0000 + +Pick has two possible parsing methods: a synchronous one (like show) +and an async one (like search). The async parser has been the default +since at least the time pick first entered contrib. I don't believe +there have been any reported problems with it during this time so we +might as well remove the sync parser and the associated defcustom. We +also remove the sync tests. + +Best wishes + +Mark + + + + +Mark Walters (2): + contrib: pick: remove sync parser + contrib: pick: remove sync tests + + contrib/notmuch-pick/notmuch-pick.el | 36 +++++----------- + contrib/notmuch-pick/run-tests.sh | 2 +- + contrib/notmuch-pick/test/emacs-pick-sync | 64 ----------------------------- + 3 files changed, 12 insertions(+), 90 deletions(-) + delete mode 100755 contrib/notmuch-pick/test/emacs-pick-sync + +-- +1.7.9.1 +