From: Edward Betts Date: Sun, 13 Mar 2016 10:57:43 +0000 (+0000) Subject: Re: [PATCH] Don't bother checking for mbox files X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=a1cf2b09732e61d3cdfbc7da6c25a7c15aa70081;p=notmuch-archives.git Re: [PATCH] Don't bother checking for mbox files --- diff --git a/ee/862f76ea1360613fc29f4099699f2e6f90d7bd b/ee/862f76ea1360613fc29f4099699f2e6f90d7bd new file mode 100644 index 000000000..a0795e739 --- /dev/null +++ b/ee/862f76ea1360613fc29f4099699f2e6f90d7bd @@ -0,0 +1,75 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 5AC606DE186A + for ; Sun, 13 Mar 2016 04:17:03 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -2.52 +X-Spam-Level: +X-Spam-Status: No, score=-2.52 tagged_above=-999 required=5 tests=[AWL=-2.510, + T_RP_MATCHES_RCVD=-0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 62z78apLrneM for ; + Sun, 13 Mar 2016 04:17:01 -0700 (PDT) +X-Greylist: delayed 1154 seconds by postgrey-1.35 at arlo; + Sun, 13 Mar 2016 04:17:00 PDT +Received: from 4angle.com (4angle.com [82.145.46.9]) + by arlo.cworth.org (Postfix) with ESMTPS id D4D846DE1868 + for ; Sun, 13 Mar 2016 04:17:00 -0700 (PDT) +Received: from cpc91242-cmbg18-2-0-cust1730.5-4.cable.virginm.net + ([82.8.134.195] helo=x230) + by 4angle.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) + (Exim 4.86) (envelope-from ) id 1af3iR-00041S-B6 + for notmuch@notmuchmail.org; Sun, 13 Mar 2016 10:57:43 +0000 +Received: from edward by x230 with local (Exim 4.86_2) + (envelope-from ) id 1af3iR-00032S-0g + for notmuch@notmuchmail.org; Sun, 13 Mar 2016 10:57:43 +0000 +Date: Sun, 13 Mar 2016 10:57:43 +0000 +From: Edward Betts +To: notmuch@notmuchmail.org +Subject: Re: [PATCH] Don't bother checking for mbox files +Message-ID: <20160313105742.GA9173@4angle.com> +References: <86io0v9oum.fsf@hiro.keithp.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <86io0v9oum.fsf@hiro.keithp.com> +User-Agent: Mutt/1.5.24 (2015-08-30) +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 13 Mar 2016 11:17:03 -0000 + +Keith Packard wrote: +> Postfix adds mbox-style From lines when used in combination with +> maildrop or .forward files. If they have another line starting with +> 'From ' in them, notmuch complains about them not being mail files. +> +> If we assume the user hasn't screwed up and misconfigured their mail +> system, then we can safely ignore whether the file started with an +> mbox header and just parse it as a single-message file. + +I think it is fine to go ahead with this change. At the same time the +behaviour of Postfix should be corrected so it doesn't add mbox-style From +lines to mails in maildir format. + +The same problem existed in the Debian exim4 config. I filed a bug, it was +fixed: https://bugs.debian.org/769396 + +Here is a bug in maildrop suggesting that it should strip the mbox-style From +line from the top of mails: https://bugs.debian.org/737383 + +-- +Edward.