From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Tue, 5 Nov 2013 18:50:55 +0000 (+0200)
Subject: Re: [PATCH v2 00/11] compactor changes v2
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9f8153bcdaac946d529afc336d1b417ebea9af2c;p=notmuch-archives.git

Re: [PATCH v2 00/11] compactor changes v2
---

diff --git a/4d/0e1d5bc69f8fbe604f80844b599db9e904f2b4 b/4d/0e1d5bc69f8fbe604f80844b599db9e904f2b4
new file mode 100644
index 000000000..201b7b3e6
--- /dev/null
+++ b/4d/0e1d5bc69f8fbe604f80844b599db9e904f2b4
@@ -0,0 +1,85 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 0A17B429E56
+	for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 10:51:09 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Hq2MmpltExNs for <notmuch@notmuchmail.org>;
+	Tue,  5 Nov 2013 10:51:03 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id D80AC431FDD
+	for <notmuch@notmuchmail.org>; Tue,  5 Nov 2013 10:51:02 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 753BD100051;
+	Tue,  5 Nov 2013 20:50:55 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
+	notmuch@notmuchmail.org
+Subject: Re: [PATCH v2 00/11] compactor changes v2
+In-Reply-To: <87k3gnqfb4.fsf@zancas.localnet>
+References: <cover.1383481295.git.jani@nikula.org>
+	<87k3gnqfb4.fsf@zancas.localnet>
+User-Agent: Notmuch/0.16+119~g219c55f (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Tue, 05 Nov 2013 20:50:55 +0200
+Message-ID: <m21u2ubs34.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 05 Nov 2013 18:51:09 -0000
+
+On Tue, Nov 05 2013, David Bremner <david@tethera.net> wrote:
+
+> Jani Nikula <jani@nikula.org> writes:
+>
+>> Hi all, this is v2 of [1], incorporating compact related patches from
+>> David, some changes from David's review, some new patches, man page
+>> update, test update.
+>>
+>> Cheers,
+>> Jani.
+>
+> Aside from the one quibble that I already sent seperately, the first 8
+> patches look OK to me. I have no technical objections to the last 3, but
+> since the change the UI, I'd like to wait a bit for more input from
+> other people.
+
+
+The whole series looks OK to me. The only thing I'm, a bit worried about
+what happens is I Ctrl-C compaction at any state. Is it possible that I
+end up with corrupted database ? Someone may accidentally execute
+notmuch compact -- for example by picking the command from history.
+
+If it is possible what is the likelihood that happening (also comparing
+w/ notmuch tag, notmuch new & notmuch insert managing to corrupt database)
+
+I personally would like to be sure. OTOH if others don't see issue
+there (perhaps with a good reason) I'm fine with the patches as those
+are now.
+
+
+Tomi
+
+