From: Ben Gamari Date: Tue, 5 Nov 2013 19:26:29 +0000 (+1900) Subject: Re: [PATCH v2 00/11] compactor changes v2 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9f03382ef3bea949cd9398e00faca73f1fccf42e;p=notmuch-archives.git Re: [PATCH v2 00/11] compactor changes v2 --- diff --git a/5f/b9bd79641c16455b4f4b127932fcdc68ff098e b/5f/b9bd79641c16455b4f4b127932fcdc68ff098e new file mode 100644 index 000000000..7215afd5d --- /dev/null +++ b/5f/b9bd79641c16455b4f4b127932fcdc68ff098e @@ -0,0 +1,132 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5CD32431E82 + for ; Tue, 5 Nov 2013 11:26:42 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 8h5XgtpRI0JT for ; + Tue, 5 Nov 2013 11:26:35 -0800 (PST) +Received: from mail-qc0-f172.google.com (mail-qc0-f172.google.com + [209.85.216.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 03FED431FDD + for ; Tue, 5 Nov 2013 11:26:34 -0800 (PST) +Received: by mail-qc0-f172.google.com with SMTP id c9so5094674qcz.17 + for ; Tue, 05 Nov 2013 11:26:33 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=GJfJUTfT35FYyXnvcJU1U7DKhy3AAKsg4DKJrF9z2JA=; + b=Yx2nHtYFx6GCRUgDHx+mjWzzqvPMstEyYKzaiRUAonbTYnlyTzxF7pq7lt6kh6Wrr5 + YrE/NIMC3BI1ZWOt58LHm7bzMyl0VNGcNiEIShX6y6NrJGzvZvOCgiZmIRAftVDemjtS + TKT779VWRRN7CvxrYvFNPlwXUL1t6qJvIt454rdP0ZFqWHbwcXZ/KukfDjr4XRoLix+g + su0ak+JoFaUoPXrnD4+7r9KiJpnNOpEFaamPedBL9a9G5JBSYbt9dq8xhYvxp7KoqKpl + 1DtXmLHx8rdtu+0Tx+NpPVN8dI0Qneh2iwuqaJcikLgFeP2i6sbP2wVByNT46JNUahdV + jkeQ== +X-Received: by 10.224.32.66 with SMTP id b2mr32196682qad.80.1383679593416; + Tue, 05 Nov 2013 11:26:33 -0800 (PST) +Received: from localhost (physicsnat56.physics.umass.edu. [128.119.50.38]) + by mx.google.com with ESMTPSA id u3sm61638010qej.8.2013.11.05.11.26.32 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Tue, 05 Nov 2013 11:26:32 -0800 (PST) +From: Ben Gamari +To: Tomi Ollila , David Bremner , + Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 00/11] compactor changes v2 +In-Reply-To: +References: + <87k3gnqfb4.fsf@zancas.localnet> + +User-Agent: Notmuch/0.16+107~g1ef2773 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Tue, 05 Nov 2013 14:26:29 -0500 +Message-ID: <87wqkmhcpm.fsf@gmail.com> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 05 Nov 2013 19:26:42 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +Tomi Ollila writes: + +> On Tue, Nov 05 2013, David Bremner wrote: +> +>> Jani Nikula writes: +>> +>>> Hi all, this is v2 of [1], incorporating compact related patches from +>>> David, some changes from David's review, some new patches, man page +>>> update, test update. +>>> +>>> Cheers, +>>> Jani. +>> +>> Aside from the one quibble that I already sent seperately, the first 8 +>> patches look OK to me. I have no technical objections to the last 3, but +>> since the change the UI, I'd like to wait a bit for more input from +>> other people. +> +> +> The whole series looks OK to me. The only thing I'm, a bit worried about +> what happens is I Ctrl-C compaction at any state. Is it possible that I +> end up with corrupted database ? Someone may accidentally execute +> notmuch compact -- for example by picking the command from history. +> +You should in principle never end up in a situation where the original +database is corrupted. Xapian's Compactor interface reads from the +existing database and writes out the compacted database to a new +directory. The notmuch compact command keeps the original database in +place until the last possible moment. + +When the compacted database is completely constructed it, deletes or +moves the old database out of the way and then moves the new database +into place. The worst thing that could happen is that you manage to +interrupt the process between deleting the old database and moving the +new one into place (a very small window). In this case you'd simply need +to move the new database into place manually (although you'd need to +figure out where the compacted database is located). +=20=20 +Cheers, + +=2D Ben + + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.14 (GNU/Linux) + +iQEcBAEBAgAGBQJSeUZlAAoJEErkyLZmeNiDgewH/07rMTKEyc8J5AYoyRQK8HcU +94ehZNt+xwKl/N6knhX5UE+KioJdXthCIDdTAiumLafZIwn6bQ6VtQgv+YrCBgVO +C5Ay8UVTnK8gd6A7tqIAHPJPo8NC8WakccgbuPrTPDak1pPFgkiTfzg8LTmtKl7c +tUBAcbpS3cBAPdAs/J948xtHpDQqr++tSxgH3cc0WGzlmBJbYszS9rwYWyCo5dX6 +dflXlcBbIDpcl4kn5+yHClc5024c6Riacu9XapXutCrs9j1hARKu+AEycupn4fLr +qm+WcZ3OQbxI4Bhaomkizmpdj0nlinpfERF0Q/+qkV2l0RJKs+IEJ5xjlDqfSyA= +=MnQw +-----END PGP SIGNATURE----- +--=-=-=--