From: David Edmondson Date: Tue, 9 Feb 2016 20:24:38 +0000 (+0000) Subject: Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l' X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9eace8061356a5c0e2cdcebf696eb56ffea608ef;p=notmuch-archives.git Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l' --- diff --git a/a1/e3fe9dab2a14522337f03465586a1b091e0e45 b/a1/e3fe9dab2a14522337f03465586a1b091e0e45 new file mode 100644 index 000000000..adc11121c --- /dev/null +++ b/a1/e3fe9dab2a14522337f03465586a1b091e0e45 @@ -0,0 +1,121 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id F34E06DE0231 + for ; Tue, 9 Feb 2016 12:24:45 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.064 +X-Spam-Level: +X-Spam-Status: No, score=-0.064 tagged_above=-999 required=5 tests=[AWL=0.003, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652, + UNPARSEABLE_RELAY=0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id uwXFuUlQF3jz for ; + Tue, 9 Feb 2016 12:24:43 -0800 (PST) +Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com + [74.125.82.65]) by arlo.cworth.org (Postfix) with ESMTPS id 6D8CE6DE01D3 for + ; Tue, 9 Feb 2016 12:24:43 -0800 (PST) +Received: by mail-wm0-f65.google.com with SMTP id p63so25219wmp.1 + for ; Tue, 09 Feb 2016 12:24:43 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=dme-org.20150623.gappssmtp.com; s=20150623; + h=to:subject:in-reply-to:references:from:date:message-id:mime-version + :content-type; bh=H2xnsPje8F2GmbzqJ0v5WnPX3HPWWjDZXoOZdhzPsBA=; + b=nytkSuSHjOCMbmAtSYMIKPp5z9EDagvgKtx0uFoxUB1Of6tv8pu2mhITYZcNiAcnoC + IAJ4xyZVu+7hVgfgmt1lb0pOz0rOUPwdGdNHcWJSd/HWg5P8LDd3BQl4OFdRsO/VghTJ + wLMyEJnp1xhMu4XDgLaIFq/4stjO0381QPQDf/xiZ95cesx0r/QIPNbzwTbGG0Uq5UOn + Wr7PmvBQl+LzhmNaYocgFxwF7ZoysBsoeLisV3Z0rwplYogVylJxChRi3rBNm5++xoOk + cEU43YCJLeh2NtCsaQTAcGEyRB7BoNQur0xQewJkNpbBqLE3sPP9Sq874R7KnmhUPwYg + ZCIA== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:from:date + :message-id:mime-version:content-type; + bh=H2xnsPje8F2GmbzqJ0v5WnPX3HPWWjDZXoOZdhzPsBA=; + b=OCrbzOFTfiAnJ+9OgQFMCG976sHsKf6wsh4XTu8qspHIROheBr73wlBWjDw0WiUHVR + Xs7n/CBypYu4pkw1ubyP0pnMPSQAcar5gSDI59myEpjMP42A1SXFER/D21PHZ8LV2vbZ + hvn7nyDoh6FHjF9lD3IJa/XWJxW9cl1tU5iUfBPTPfrOjxYJJLiex/zHWXn6/I5wFGyq + z9NQvwo84z44vC6FPxg7NorEXcl7HdiQIMwmu2/+bs8bHQOqM/ySv8CyfiNfAGjDoV0c + KgyjoyyQzEKaPD5SGqGcC4dh59GlqQJs4Zr43J74+PkDzpgOiWtUtyhuSrCrMRMAfhRn + 4VcA== +X-Gm-Message-State: + AG10YOSPkQqgszglraxjOfM9r2/+X0oSpKk+Zhl5sjTq7oipHUZEsnEihyEMHH533hh+Qw== +X-Received: by 10.28.180.84 with SMTP id d81mr7324807wmf.42.1455049481469; + Tue, 09 Feb 2016 12:24:41 -0800 (PST) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by smtp.gmail.com with ESMTPSA id b1sm36305127wjy.0.2016.02.09.12.24.39 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Tue, 09 Feb 2016 12:24:39 -0800 (PST) +Received: from localhost (disaster-area.hh.sledj.net [local]) + by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id e4f5946b; + Tue, 9 Feb 2016 20:24:38 +0000 (UTC) +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l' +In-Reply-To: <1434182890-8047-4-git-send-email-markwalters1009@gmail.com> +References: <1434182890-8047-1-git-send-email-markwalters1009@gmail.com> + <1434182890-8047-4-git-send-email-markwalters1009@gmail.com> +From: David Edmondson +Date: Tue, 09 Feb 2016 20:24:38 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 09 Feb 2016 20:24:46 -0000 + +On Sat, Jun 13 2015, Mark Walters wrote: +> Change the key binding for filter (or "limit") in search-mode. This +> gives consistency with the new filter in show-mode, and frees 'f' for +> forward-thread in the future. + +Is there a conclusion on this change? The patch itself seems obviously +fine from a code perspective, at issue is more whether it's acceptable +to change the key binding. + +The equivalent binding in notmuch-show mode is already "l", and I think +that it makes sense to be consistent (i.e. the change should be +applied). + +> --- +> emacs/notmuch.el | 4 ++-- +> 1 file changed, 2 insertions(+), 2 deletions(-) +> +> diff --git a/emacs/notmuch.el b/emacs/notmuch.el +> index 6564816..06e3b94 100644 +> --- a/emacs/notmuch.el +> +++ b/emacs/notmuch.el +> @@ -166,7 +166,7 @@ (defvar notmuch-search-mode-map +> (define-key map "o" 'notmuch-search-toggle-order) +> (define-key map "c" 'notmuch-search-stash-map) +> (define-key map "t" 'notmuch-search-filter-by-tag) +> - (define-key map "f" 'notmuch-search-filter) +> + (define-key map "l" 'notmuch-search-filter) +> (define-key map [mouse-1] 'notmuch-search-show-thread) +> (define-key map "*" 'notmuch-search-tag-all) +> (define-key map "a" 'notmuch-search-archive-thread) +> @@ -983,7 +983,7 @@ (defun notmuch-search-toggle-order () +> (notmuch-search-refresh-view)) +> +> (defun notmuch-search-filter (query) +> - "Filter the current search results based on an additional query string. +> + "Filter or LIMIT the current search results based on an additional query string. +> +> Runs a new search matching only messages that match both the +> current search results AND the additional query string provided." +> -- +> 2.1.4