From: Tomi Ollila Date: Sun, 20 Sep 2015 12:28:38 +0000 (+0300) Subject: Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=9e6747bcb6f35865eef26d9f02f6844baf1f51a9;p=notmuch-archives.git Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default --- diff --git a/f4/39d8339df4b32f6dd5757cdbc787b9d1681040 b/f4/39d8339df4b32f6dd5757cdbc787b9d1681040 new file mode 100644 index 000000000..6ae92b5eb --- /dev/null +++ b/f4/39d8339df4b32f6dd5757cdbc787b9d1681040 @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 320D96DE1AE9 + for ; Sun, 20 Sep 2015 05:28:41 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.158 +X-Spam-Level: * +X-Spam-Status: No, score=1.158 tagged_above=-999 required=5 tests=[AWL=-0.238, + SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 25efpsF4vsHd for ; + Sun, 20 Sep 2015 05:28:39 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id D410E6DE1AE8 + for ; Sun, 20 Sep 2015 05:28:38 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 1F80D10008D; + Sun, 20 Sep 2015 15:28:39 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default +In-Reply-To: <87io75tji3.fsf@maritornes.cs.unb.ca> +References: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi> + <87io75tji3.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 20 Sep 2015 12:28:41 -0000 + +On Sun, Sep 20 2015, David Bremner wrote: + +> Tomi Ollila writes: +> +>> make test V=1 (or any other value than 0) and make test V=0 +>> works similar way as build in general +>> --- +>> +>> This is 2nd try: In first one I changed test-lib.sh -- there problem +>> was the precedence between command line argument and NOTMUCH_TEST_QUIET +>> environment variable. Here I don't see a problem there (although +>> env NOTMUCH_TEST_QUIET=1 make test V=1 will make environment variable +>> overrule the V=1 -- I am not sure who cares, though :D) +>> +>> Anyway, Someone(TM) may have better solution in mind, so let's +>> get bikeshedding going! +>> +> +> One thing I thought of was that we could replace the use of +> NOTMUCH_TEST_QUIET with e.g. NOTMUCH_TEST_VERBOSE, and have that set by +> the command line argument --verbose. This would be less work on the +> Makefile side, but I guess a bit more on the test-lib.sh side. I suppose +> it might also be an annoyance for some people currently using +> NOTMUCH_TEST_QUIET in some autobuilder setup. At the moment I can't +> think of what would really break by changing this "API", but knows. The +> current behaviour of having NOTMUCH_TEST_QUIET and --verbose completely +> independent is pretty surprising. + +There was 2 primary motivations when I did that patch (which I forgot to +mark rfc although I thought doing so) 1) that was the fastest at the time +being and 2) the --verbose is already in use in test-lib.sh. + +First thing that come to my mind is that if (-v|--v[e[r[b[o[s[e]]]]]]) +option is for the suggested purpose its current behaviour is removed +and when the option is not give user is informed how to activate "verbose" +progress -- but as said that is just first thought... + + +Making NOTMUCH_TEST_QUIET no-op is probably no annoyance to anyone... + +> +> d +> +> P.S. I hope you appreciate my classic "scope-creep" technique in +> bikeshedding. ;) + +In test-related issues that is fine by me. + + +Tomi